From 3dece0d8e3387bb2f784857964db2e2a0bf1aa02 Mon Sep 17 00:00:00 2001
From: voidlizard <dzuikov@gmail.com>
Date: Thu, 20 Mar 2025 11:15:46 +0300
Subject: [PATCH] wip

---
 hbs2-storage-ncq/lib/HBS2/Storage/NCQ.hs | 24 ++++++++++++++++++------
 hbs2-tests/test/TestCQ.hs                | 23 ++++++++++++++++++++++-
 2 files changed, 40 insertions(+), 7 deletions(-)

diff --git a/hbs2-storage-ncq/lib/HBS2/Storage/NCQ.hs b/hbs2-storage-ncq/lib/HBS2/Storage/NCQ.hs
index 4518b219..589657e1 100644
--- a/hbs2-storage-ncq/lib/HBS2/Storage/NCQ.hs
+++ b/hbs2-storage-ncq/lib/HBS2/Storage/NCQ.hs
@@ -313,7 +313,7 @@ ncqStorageRun ncq@NCQStorage{..} = flip runContT pure do
     makeWriter indexQ = do
 
       let dumpTimeout = TimeoutSec 10
-      let dumpData    = 1024 ^ 10
+      let dumpData    = fromIntegral ncqSyncSize
       let syncData    = fromIntegral ncqSyncSize
 
       writer <- ContT $ withAsync do
@@ -326,7 +326,7 @@ ncqStorageRun ncq@NCQStorage{..} = flip runContT pure do
           liftIO $ race (pause dumpTimeout) $ atomically do
             flush <- isEmptyTQueue myFlushQ <&> not
             stop  <- readTVar ncqStopped
-            bytes <- readTVar ncqLastWritten
+            bytes <- readTVar ncqNotWritten
             if bytes > dumpData || flush || stop then none else STM.retry
 
           void $ atomically (STM.flushTQueue myFlushQ)
@@ -426,7 +426,6 @@ ncqStorageRun ncq@NCQStorage{..} = flip runContT pure do
                                    , sdelta
                                    ]
              void $ Posix.fdWrite w deleted
-             debug $ "DELETED" <+> pretty hx
            fileSynchronise w
 
          stop <- readTVarIO ncqStopped
@@ -569,9 +568,9 @@ ncqStoragePut ncq@NCQStorage{..} lbs = flip runContT pure $ callCC \exit -> do
   atomically do
     ql <- readTVar ncqWriteQueue <&> HPSQ.size
     -- FIXME: hardcode
-    when (ql > 8192) STM.retry
+    -- when (ql > 8192) STM.retry
     modifyTVar ncqWriteQueue (HPSQ.insert h now lbs)
-    modifyTVar ncqNotWritten (+ (fromIntegral $ 36 + LBS.length lbs))
+    modifyTVar ncqNotWritten (+ (fromIntegral $ 4 + 32 + LBS.length lbs))
     pure (Just h)
 
 ncqLocatedSize :: Location -> Integer
@@ -783,6 +782,19 @@ ncqFixIndexes ncq@NCQStorage{..} = do
       newKey <- ncqIndexFile ncq dataName <&> fromString @FileKey
       atomically $ ncqAddTrackedFilesSTM ncq [newKey]
 
+
+-- NOTE:
+--   merely find in fossil files,
+--   because "current" is filtered on load
+--   and it's okay, we may compact only
+--   fossils
+ncqScanDeleted :: MonadUnliftIO m => NCQStorage -> m [Location]
+ncqScanDeleted ncq@NCQStorage{..} = do
+  readTVarIO ncqDeleted
+    <&> fmap fst . List.filter ((>0).snd) . HM.toList
+    >>= mapM (ncqLocate ncq)
+    <&> catMaybes
+
 ncqStorageOpen :: MonadUnliftIO m => FilePath -> m NCQStorage
 ncqStorageOpen fp = do
   ncq@NCQStorage{..} <- ncqStorageInit_ False fp
@@ -890,7 +902,7 @@ ncqStorageInit_ check path = do
   ncqRefsMem       <- newTVarIO mempty
   ncqRefsDirty     <- newTVarIO 0
 
-  let ncqSyncSize  = 32 * (1024 ^ 2)
+  let ncqSyncSize  = 64 * (1024 ^ 2)
   let ncqMinLog    =  2 * (1024 ^ 3)
   let ncqMaxLog    = 10 * (1024 ^ 3)
 
diff --git a/hbs2-tests/test/TestCQ.hs b/hbs2-tests/test/TestCQ.hs
index 875d09dd..6a291a52 100644
--- a/hbs2-tests/test/TestCQ.hs
+++ b/hbs2-tests/test/TestCQ.hs
@@ -509,6 +509,27 @@ main = do
 
           e -> throwIO $ BadFormException @C (mkList e)
 
+        entry $ bindMatch "test:ncq:raw:scan-deleted" $ nil_ \case
+          [StringLike fn] -> liftIO $ flip runContT pure do
+
+            ncq <- lift $ ncqStorageOpen fn
+
+            writer <- ContT $ withAsync $ ncqStorageRun ncq
+            link writer
+
+            ContT $ bracket none $ const do
+              none
+
+            what <- lift $ ncqScanDeleted ncq
+
+            for_ what $ \l -> do
+              liftIO $ print l
+
+            liftIO $ ncqStorageStop ncq
+
+            wait writer
+
+          e -> throwIO $ BadFormException @C (mkList e)
 
         entry $ bindMatch "test:ncq:raw:del-some" $ nil_ \case
           [StringLike fn] -> liftIO $ flip runContT pure do
@@ -527,7 +548,7 @@ main = do
 
             for_ hashes $ \h -> runMaybeT do
               liftIO do
-                print $ "delete" <+> pretty h
+                -- print $ "delete" <+> pretty h
                 ncqStorageDel ncq h
 
             liftIO $ ncqStorageStop ncq