From 15bec4852219ffef5b1c8bbbeb3a13721c373dff Mon Sep 17 00:00:00 2001
From: voidlizard <dzuikov@gmail.com>
Date: Sun, 13 Jul 2025 16:56:01 +0300
Subject: [PATCH] wip, trying PendingEntry state

---
 .../lib/HBS2/Storage/NCQ/Types.hs             |  7 +++---
 hbs2-storage-ncq/lib/HBS2/Storage/NCQ2.hs     | 24 ++++++++++---------
 2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/hbs2-storage-ncq/lib/HBS2/Storage/NCQ/Types.hs b/hbs2-storage-ncq/lib/HBS2/Storage/NCQ/Types.hs
index 324cf66e..62f090c3 100644
--- a/hbs2-storage-ncq/lib/HBS2/Storage/NCQ/Types.hs
+++ b/hbs2-storage-ncq/lib/HBS2/Storage/NCQ/Types.hs
@@ -90,11 +90,12 @@ data CachedEntry =
               , cachedNway       :: NWayHash
               , cachedTs         :: TVar TimeSpec
               }
+  | PendingEntry {}
 
 instance Show CachedEntry where
-  show _ = "CachedEntry{...}"
-
-
+  show = \case
+    CachedEntry{}  -> "CachedEntry{...}"
+    PendingEntry{} -> "PendingEntry{...}"
 
 newtype NCQFullRecordLen a =
   NCQFullRecordLen a
diff --git a/hbs2-storage-ncq/lib/HBS2/Storage/NCQ2.hs b/hbs2-storage-ncq/lib/HBS2/Storage/NCQ2.hs
index ba1d9888..ba0864e0 100644
--- a/hbs2-storage-ncq/lib/HBS2/Storage/NCQ2.hs
+++ b/hbs2-storage-ncq/lib/HBS2/Storage/NCQ2.hs
@@ -144,7 +144,6 @@ data NCQStorage2 =
   , ncqMergeSem       :: TSem
   , ncqSyncNo         :: TVar Int
   , ncqTrackedFiles   :: TVar (HashPSQ FileKey FilePrio (Maybe CachedEntry))
-  , ncqStaged         :: TVar (HashSet FileKey)
   , ncqStateVersion   :: TVar StateVersion
   , ncqStateUsage     :: TVar (IntMap (Int, HashSet FileKey))
   , ncqCachedEntries  :: TVar Int
@@ -177,7 +176,6 @@ ncqStorageOpen2 fp upd = do
   ncqMergeSem        <- atomically (newTSem 1)
   ncqSyncNo          <- newTVarIO 0
   ncqTrackedFiles    <- newTVarIO HPSQ.empty
-  ncqStaged          <- newTVarIO mempty
   ncqStateVersion    <- newTVarIO 0
   ncqStateUsage      <- newTVarIO mempty
   ncqCachedEntries   <- newTVarIO 0
@@ -306,7 +304,7 @@ ncqLocate2 ncq@NCQStorage2{..} href = flip runContT pure $ callCC \exit -> do
 
   tracked <- readTVarIO ncqTrackedFiles <&> HPSQ.toList
 
-  for_ tracked $ \(fk, prio, mCached) -> do
+  for_ tracked $ \(fk, prio, mCached) -> callCC \skip -> do
     case mCached of
       Just CachedEntry{..} -> do
         lookupEntry href (cachedMmapedIdx, cachedNway) >>= \case
@@ -315,10 +313,18 @@ ncqLocate2 ncq@NCQStorage2{..} href = flip runContT pure $ callCC \exit -> do
             atomically $ writeTVar cachedTs now
             exit (Just $ InFossil cachedMmapedData offset size)
 
+      Just PendingEntry {} -> none
+
       Nothing ->  useVersion do
         let indexFile = ncqGetFileName ncq (toFileName (IndexFile fk))
         let dataFile  = ncqGetFileName ncq (toFileName (DataFile fk))
 
+        idxHere <- doesFileExist indexFile
+
+        unless idxHere do
+          err $ red "missed index" <+> "in ncqLocate" <+> pretty fk
+          skip ()
+
         (idxBs, idxNway) <- liftIO (nwayHashMMapReadOnly indexFile)
                              >>= orThrow (NCQStorageCantMapFile indexFile)
 
@@ -395,7 +401,6 @@ ncqStorageRun2 ncq@NCQStorage2{..} = flip runContT pure do
         -- notice $ yellow "indexing" <+> pretty fname
         idx <- ncqRunTaskNoMatterWhat ncq (ncqIndexFile ncq (DataFile fk))
         ncqRunTaskNoMatterWhat ncq $ ncqStateUpdate ncq [F 0 fk]
-        -- ncqAddTrackedFile ncq (DataFile fk)
         nwayHashMMapReadOnly idx >>= \case
           Nothing -> err $ "can't open index" <+> pretty idx
           Just (bs,nway) -> do
@@ -468,9 +473,10 @@ ncqStorageRun2 ncq@NCQStorage2{..} = flip runContT pure do
                 else do
                   appendTailSection fh >> liftIO (fileSynchronise fh)
                   -- FIXME: slow!
-                  liftIO (ncqStateUpdate ncq [F 0 fk])
+                  -- liftIO (ncqStateUpdate ncq [F 0 fk])
                   atomically do
-                    modifyTVar ncqStaged (HS.insert fk)
+                    -- to make it appear in state, but to ignore until indexed
+                    modifyTVar ncqTrackedFiles (HPSQ.insert fk (FilePrio (Down 0)) (Just PendingEntry))
                     writeTVar  ncqStorageSyncReq False
                     modifyTVar' ncqSyncNo succ
 
@@ -873,11 +879,7 @@ ncqStateUpdate me@NCQStorage2{..} ops' = flip runContT pure $ callCC \exit -> do
 
 ncqDumpCurrentState :: MonadUnliftIO m => NCQStorage2 -> m ()
 ncqDumpCurrentState me@NCQStorage2{..} = do
-  keys <- atomically do
-             a1 <- readTVar ncqTrackedFiles <&> HPSQ.keys
-             a2 <- readTVar ncqStaged
-             pure (HS.toList (a2 <> HS.fromList a1))
-
+  keys <- readTVarIO ncqTrackedFiles <&> List.sort . HPSQ.keys
   name <- ncqGetNewStateName me
   writeBinaryFileDurableAtomic name (BS8.unlines [coerce k | k <- keys])