procxx
/
kepka
mirror of https://github.com/procxx/kepka.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fixed crash in Observers (removing an observer inside notify call).

This commit is contained in:
John Preston 2016-09-01 21:12:04 -04:00
parent f8e1063541
commit d864a8d8eb
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Telegram/SourceFiles/core/observer.h
View File

@ -103,7 +103,12 @@ public:
void notify(Flags flags, Args&&... args) { void notify(Flags flags, Args&&... args) {
t_assert(started()); t_assert(started());
for (auto &entry : _list->entries) { auto &entries = _list->entries;
// This way of iterating (i < entries.size() should be used
// because some entries can be removed from the end of the
// entries list while the loop is still running.
for (int i = 0; i < entries.size(); ++i) {
auto &entry = entries[i];
if (!entry.handler.isNull() && (flags & entry.flags)) { if (!entry.handler.isNull() && (flags & entry.flags)) {
entry.handler.call(std_::forward<Args>(args)...); entry.handler.call(std_::forward<Args>(args)...);
} }
@ -131,7 +136,7 @@ private:
t_assert(that->started()); t_assert(that->started());
auto &entries(that->_list->entries); auto &entries = that->_list->entries;
if (entries.size() <= connectionIndex) return; if (entries.size() <= connectionIndex) return;
if (entries.size() == connectionIndex + 1) { if (entries.size() == connectionIndex + 1) {