procxx
/
kepka
mirror of https://github.com/procxx/kepka.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix crash: transfer QMenu ownership to PopupMenu. Not tested.

This commit is contained in:
John Preston 2016-10-24 18:35:26 +03:00
parent 1cfe9d0ff5
commit c8a379e85e
3 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Telegram/SourceFiles/ui/flatinput.cpp
View File

@ -243,7 +243,7 @@ void FlatInput::updatePlaceholderText() {
} }
void FlatInput::contextMenuEvent(QContextMenuEvent *e) { void FlatInput::contextMenuEvent(QContextMenuEvent *e) {
if (QMenu *menu = createStandardContextMenu()) { if (auto menu = createStandardContextMenu()) {
(new PopupMenu(menu))->popup(e->globalPos()); (new PopupMenu(menu))->popup(e->globalPos());
} }
} }
@ -1281,7 +1281,7 @@ void InputArea::Inner::paintEvent(QPaintEvent *e) {
} }
void InputArea::Inner::contextMenuEvent(QContextMenuEvent *e) { void InputArea::Inner::contextMenuEvent(QContextMenuEvent *e) {
if (QMenu *menu = createStandardContextMenu()) { if (auto menu = createStandardContextMenu()) {
(new PopupMenu(menu))->popup(e->globalPos()); (new PopupMenu(menu))->popup(e->globalPos());
} }
} }
@ -2028,7 +2028,7 @@ void InputField::Inner::paintEvent(QPaintEvent *e) {
} }
void InputField::Inner::contextMenuEvent(QContextMenuEvent *e) { void InputField::Inner::contextMenuEvent(QContextMenuEvent *e) {
if (QMenu *menu = createStandardContextMenu()) { if (auto menu = createStandardContextMenu()) {
(new PopupMenu(menu))->popup(e->globalPos()); (new PopupMenu(menu))->popup(e->globalPos());
} }
} }
@ -2236,7 +2236,7 @@ void MaskedInputField::updatePlaceholderText() {
} }
void MaskedInputField::contextMenuEvent(QContextMenuEvent *e) { void MaskedInputField::contextMenuEvent(QContextMenuEvent *e) {
if (QMenu *menu = createStandardContextMenu()) { if (auto menu = createStandardContextMenu()) {
(new PopupMenu(menu))->popup(e->globalPos()); (new PopupMenu(menu))->popup(e->globalPos());
} }
} }

2
Telegram/SourceFiles/ui/flattextarea.cpp
View File

@ -1420,7 +1420,7 @@ void FlatTextarea::dropEvent(QDropEvent *e) {
} }
void FlatTextarea::contextMenuEvent(QContextMenuEvent *e) { void FlatTextarea::contextMenuEvent(QContextMenuEvent *e) {
if (QMenu *menu = createStandardContextMenu()) { if (auto menu = createStandardContextMenu()) {
(new PopupMenu(menu))->popup(e->globalPos()); (new PopupMenu(menu))->popup(e->globalPos());
} }
} }

13
Telegram/SourceFiles/ui/popupmenu.cpp
View File

@ -35,7 +35,7 @@ PopupMenu::PopupMenu(const style::PopupMenu &st) : TWidget(nullptr)
init(); init();
} }
PopupMenu::PopupMenu(QMenu *menu, const style::PopupMenu &st) : TWidget(0) PopupMenu::PopupMenu(QMenu *menu, const style::PopupMenu &st) : TWidget(nullptr)
, _st(st) , _st(st)
, _menu(menu) , _menu(menu)
, _itemHeight(_st.itemPadding.top() + _st.itemFont->height + _st.itemPadding.bottom()) , _itemHeight(_st.itemPadding.top() + _st.itemFont->height + _st.itemPadding.bottom())
@ -43,6 +43,9 @@ PopupMenu::PopupMenu(QMenu *menu, const style::PopupMenu &st) : TWidget(0)
, _shadow(_st.shadow) , _shadow(_st.shadow)
, a_opacity(1) , a_opacity(1)
, _a_hide(animation(this, &PopupMenu::step_hide)) { , _a_hide(animation(this, &PopupMenu::step_hide)) {
_menu->setParent(this);
_menu->hide();
init(); init();
for (auto action : menu->actions()) { for (auto action : menu->actions()) {
addAction(action); addAction(action);
@ -72,11 +75,11 @@ QAction *PopupMenu::addAction(const QString &text, const QObject *receiver, cons
QAction *PopupMenu::addAction(QAction *a) { QAction *PopupMenu::addAction(QAction *a) {
connect(a, SIGNAL(changed()), this, SLOT(actionChanged())); connect(a, SIGNAL(changed()), this, SLOT(actionChanged()));
_actions.push_back(a); _actions.push_back(a);
if (a->menu()) { if (auto submenu = a->menu()) {
_menus.push_back(new PopupMenu(a->menu())); _menus.push_back(new PopupMenu(submenu));
_menus.back()->deleteOnHide(false); _menus.back()->deleteOnHide(false);
} else { } else {
_menus.push_back(0); _menus.push_back(nullptr);
} }
_texts.push_back(QString()); _texts.push_back(QString());
_shortcutTexts.push_back(QString()); _shortcutTexts.push_back(QString());
@ -503,7 +506,7 @@ void PopupMenu::showMenu(const QPoint &p, PopupMenu *parent, PressSource source)
PopupMenu::~PopupMenu() { PopupMenu::~PopupMenu() {
clearActions(true); clearActions(true);
delete _menu;
#if defined Q_OS_LINUX32 || defined Q_OS_LINUX64 #if defined Q_OS_LINUX32 || defined Q_OS_LINUX64
if (auto w = App::wnd()) { if (auto w = App::wnd()) {
w->onReActivate(); w->onReActivate();