Fix file references for faved stickers.

Telegram/SourceFiles/chat_helpers/stickers.cpp

@@ -176,9 +176,17 @@ void UndoInstallLocally(uint64 setId) {
 		LayerOption::KeepOther);
 }
 
-bool IsFaved(not_null<DocumentData*> document) {
+bool IsFaved(not_null<const DocumentData*> document) {
-	auto it = Auth().data().stickerSets().constFind(FavedSetId);
+	const auto it = Auth().data().stickerSets().constFind(FavedSetId);
-	return (it != Auth().data().stickerSets().cend()) && it->stickers.contains(document);
+	if (it == Auth().data().stickerSets().cend()) {
+		return false;
+	}
+	for (const auto sticker : it->stickers) {
+		if (sticker == document) {
+			return true;
+		}
+	}
+	return false;
 }
 
 void CheckFavedLimit(Set &set) {

Telegram/SourceFiles/chat_helpers/stickers.h

@@ -69,7 +69,7 @@ void ApplyArchivedResult(const MTPDmessages_stickerSetInstallResultArchive &d);
 bool ApplyArchivedResultFake(); // For testing.
 void InstallLocally(uint64 setId);
 void UndoInstallLocally(uint64 setId);
-bool IsFaved(not_null<DocumentData*> document);
+bool IsFaved(not_null<const DocumentData*> document);
 void SetFaved(not_null<DocumentData*> document, bool faved);
 
 void SetsReceived(const QVector<MTPStickerSet> &data, int32 hash);

Telegram/SourceFiles/data/data_document.cpp

@@ -1000,7 +1000,11 @@ ImagePtr DocumentData::getStickerThumb() {
 
 Data::FileOrigin DocumentData::stickerSetOrigin() const {
 	if (const auto data = sticker()) {
-		return data->setOrigin();
+		if (const auto result = data->setOrigin()) {
+			return result;
+		} else if (Stickers::IsFaved(this)) {
+			return Data::FileOriginStickerSet(Stickers::FavedSetId, 0);
+		}
 	}
 	return Data::FileOrigin();
 }

Telegram/SourceFiles/ui/images.cpp

@@ -1408,6 +1408,8 @@ StorageImage *getImage(const StorageImageLocation &location, int32 size) {
 	StorageImages::const_iterator i = storageImages.constFind(key);
 	if (i == storageImages.cend()) {
 		i = storageImages.insert(key, new StorageImage(location, size));
+	} else {
+		i.value()->refreshFileReference(location.fileReference());
 	}
 	return i.value();
 }
@@ -1418,11 +1420,14 @@ StorageImage *getImage(const StorageImageLocation &location, const QByteArray &b
 	if (i == storageImages.cend()) {
 		QByteArray bytesArr(bytes);
 		i = storageImages.insert(key, new StorageImage(location, bytesArr));
-	} else if (!i.value()->loaded()) {
+	} else {
-		QByteArray bytesArr(bytes);
+		i.value()->refreshFileReference(location.fileReference());
-		i.value()->setData(bytesArr);
+		if (!i.value()->loaded()) {
-		if (!location.isNull()) {
+			QByteArray bytesArr(bytes);
-			Local::writeImage(key, StorageImageSaved(bytes));
+			i.value()->setData(bytesArr);
+			if (!location.isNull()) {
+				Local::writeImage(key, StorageImageSaved(bytes));
+			}
 		}
 	}
 	return i.value();

Telegram/SourceFiles/ui/images.h

@@ -153,7 +153,9 @@ public:
 		return _fileReference;
 	}
 	void refreshFileReference(const QByteArray &data) {
-		_fileReference = data;
+		if (!data.isEmpty()) {
+			_fileReference = data;
+		}
 	}
 
 	static StorageImageLocation FromMTP(
@@ -511,6 +513,9 @@ public:
 	const StorageImageLocation &location() const override {
 		return _location;
 	}
+	void refreshFileReference(const QByteArray &data) {
+		_location.refreshFileReference(data);
+	}
 
 protected:
 	void setInformation(int32 size, int32 width, int32 height) override;