From 48548e93033f76bc14a425a2ccd7e2227758312b Mon Sep 17 00:00:00 2001
From: John Preston <johnprestonmail@gmail.com>
Date: Fri, 2 Nov 2018 17:52:55 +0400
Subject: [PATCH] Improve phrases for custom langpacks.

---
 Telegram/Resources/langs/lang.strings         |  5 ++
 .../SourceFiles/lang/lang_cloud_manager.cpp   | 80 +++++++++++++++++--
 2 files changed, 77 insertions(+), 8 deletions(-)

diff --git a/Telegram/Resources/langs/lang.strings b/Telegram/Resources/langs/lang.strings
index cf8d7a8f5..1638c2334 100644
--- a/Telegram/Resources/langs/lang.strings
+++ b/Telegram/Resources/langs/lang.strings
@@ -1793,6 +1793,11 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL
 "lng_language_switch_about" = "You are about to apply a custom language pack {lang_name} that is {percent}% complete.\n\nThis will translate the entire interface. You can suggest corrections in the {link}.\n\nYou can change your language back at any time in Settings.";
 "lng_language_switch_link" = "translation panel";
 "lng_language_switch_apply" = "Change";
+"lng_language_not_found" = "Sorry, this language pack doesn't exist.";
+"lng_language_already" = "You're already using this language pack. You can change your language back in Settings.";
+"lng_language_not_ready_title" = "Insufficient data";
+"lng_language_not_ready_about" = "Unfortunately, this custom language pack ({lang_name}) doesn't contain data for Telegram Desktop. You can contribute to this language pack using the {link}.";
+"lng_language_not_ready_link" = "translations platform";
 
 // Wnd specific
 
diff --git a/Telegram/SourceFiles/lang/lang_cloud_manager.cpp b/Telegram/SourceFiles/lang/lang_cloud_manager.cpp
index 6a16d7a42..5e0ce4902 100644
--- a/Telegram/SourceFiles/lang/lang_cloud_manager.cpp
+++ b/Telegram/SourceFiles/lang/lang_cloud_manager.cpp
@@ -43,12 +43,28 @@ private:
 
 };
 
+class NotReadyBox : public BoxContent {
+public:
+	NotReadyBox(
+		QWidget*,
+		const MTPDlangPackLanguage &data,
+		const QString &editLink);
+
+protected:
+	void prepare() override;
+
+private:
+	QString _name;
+	QString _editLink;
+
+};
+
 ConfirmSwitchBox::ConfirmSwitchBox(
 	QWidget*,
 	const MTPDlangPackLanguage &data,
 	const QString &editLink,
 	Fn<void()> apply)
-: _name(qs(data.vname))
+: _name(qs(data.vnative_name))
 , _percent(data.vtranslated_count.v * 100 / data.vstrings_count.v)
 , _editLink(editLink)
 , _apply(std::move(apply)) {
@@ -84,7 +100,8 @@ void ConfirmSwitchBox::prepare() {
 		this,
 		object_ptr<Ui::FlatLabel>(
 			this,
-			rpl::single(text)),
+			rpl::single(text),
+			st::boxLabel),
 		QMargins{ st::boxPadding.left(), 0, st::boxPadding.right(), 0 });
 	content->entity()->setClickHandlerFilter([=](auto&&...) {
 		UrlClickHandler::Open(_editLink);
@@ -98,6 +115,50 @@ void ConfirmSwitchBox::prepare() {
 	});
 	addButton(langFactory(lng_cancel), [=] { closeBox(); });
 
+	content->resizeToWidth(st::boxWideWidth);
+	content->heightValue(
+	) | rpl::start_with_next([=](int height) {
+		setDimensions(st::boxWideWidth, height);
+	}, lifetime());
+}
+
+NotReadyBox::NotReadyBox(
+	QWidget*,
+	const MTPDlangPackLanguage &data,
+	const QString &editLink)
+: _name(qs(data.vnative_name))
+, _editLink(editLink) {
+}
+
+void NotReadyBox::prepare() {
+	setTitle(langFactory(lng_language_not_ready_title));
+
+	auto link = TextWithEntities{ lang(lng_language_not_ready_link) };
+	link.entities.push_back(EntityInText(
+		EntityInTextCustomUrl,
+		0,
+		link.text.size(),
+		QString("internal:go_to_translations")));
+	auto name = TextWithEntities{ _name };
+	const auto text = lng_language_not_ready_about__generic(
+		lt_lang_name,
+		name,
+		lt_link,
+		link);
+	auto content = Ui::CreateChild<Ui::PaddingWrap<Ui::FlatLabel>>(
+		this,
+		object_ptr<Ui::FlatLabel>(
+			this,
+			rpl::single(text),
+			st::boxLabel),
+		QMargins{ st::boxPadding.left(), 0, st::boxPadding.right(), 0 });
+	content->entity()->setClickHandlerFilter([=](auto&&...) {
+		UrlClickHandler::Open(_editLink);
+		return false;
+	});
+
+	addButton(langFactory(lng_box_ok), [=] { closeBox(); });
+
 	content->resizeToWidth(st::boxWidth);
 	content->heightValue(
 	) | rpl::start_with_next([=](int height) {
@@ -346,6 +407,7 @@ void CloudManager::switchWithWarning(const QString &id) {
 	Expects(!id.isEmpty());
 
 	if (LanguageIdOrDefault(_langpack.id()) == id) {
+		Ui::show(Box<InformBox>(lang(lng_language_already)));
 		return;
 	}
 
@@ -356,6 +418,9 @@ void CloudManager::switchWithWarning(const QString &id) {
 	)).done([=](const MTPLangPackLanguage &result) {
 		_switchingToLanguageRequest = 0;
 		result.match([=](const MTPDlangPackLanguage &data) {
+			const auto link = "https://translations.telegram.org/"
+				+ id
+				+ '/';
 			if (data.vtranslated_count.v > 0) {
 				const auto pluralId = qs(data.vplural_code);
 				const auto baseId = qs(data.vbase_lang_code);
@@ -363,17 +428,16 @@ void CloudManager::switchWithWarning(const QString &id) {
 					Local::pushRecentLanguage(ParseLanguage(result));
 					performSwitchAndRestart(id, pluralId, baseId);
 				};
-				Ui::show(Box<ConfirmSwitchBox>(
-					data,
-					"https://translations.telegram.org/" + id + '/',
-					perform));
+				Ui::show(Box<ConfirmSwitchBox>(data, link, perform));
 			} else {
-				Ui::show(Box<InformBox>(
-					"not translated :("));
+				Ui::show(Box<NotReadyBox>(data, link));
 			}
 		});
 	}).fail([=](const RPCError &error) {
 		_switchingToLanguageRequest = 0;
+		if (error.type() == "LANG_CODE_NOT_SUPPORTED") {
+			Ui::show(Box<InformBox>(lang(lng_language_not_found)));
+		}
 	}).send();
 }