Fix working with layers.

Regression was introduced in df64c97.

New base::flags work correctly only if all mutually exclusive flag
values use mutually exclusive bits (a & b == 0 for exclusive (a, b)).

Closes #3856.

Telegram/SourceFiles/core/utils.h

@@ -570,12 +570,12 @@ enum ForwardWhatMessages {
 };
 
 enum ShowLayerOption {
-	CloseOtherLayers = 0x00,
+	CloseOtherLayers     = (1 << 0),
-	KeepOtherLayers = 0x01,
+	KeepOtherLayers      = (1 << 1),
-	ShowAfterOtherLayers = 0x03,
+	ShowAfterOtherLayers = (1 << 2),
 
-	AnimatedShowLayer = 0x00,
+	AnimatedShowLayer    = (1 << 3),
-	ForceFastShowLayer = 0x04,
+	ForceFastShowLayer   = (1 << 4),
 };
 using ShowLayerOptions = base::flags<ShowLayerOption>;
 inline constexpr auto is_flag_type(ShowLayerOption) { return true; };

Telegram/SourceFiles/dialogs/dialogs_inner_widget.h

@@ -175,11 +175,11 @@ private:
 
 	void itemRemoved(HistoryItem *item);
 	enum class UpdateRowSection {
-		Default = 0x01,
+		Default       = (1 << 0),
-		Filtered = 0x02,
+		Filtered      = (1 << 1),
-		PeerSearch = 0x04,
+		PeerSearch    = (1 << 2),
-		MessageSearch = 0x08,
+		MessageSearch = (1 << 3),
-		All = 0x0F,
+		All           = Default | Filtered | PeerSearch | MessageSearch,
 	};
 	using UpdateRowSections = base::flags<UpdateRowSection>;
 	friend inline constexpr auto is_flag_type(UpdateRowSection) { return true; };

Telegram/SourceFiles/history/history_item.h

@@ -172,8 +172,8 @@ struct HistoryMessageReply : public RuntimeComponent<HistoryMessageReply> {
 	void itemRemoved(HistoryMessage *holder, HistoryItem *removed);
 
 	enum class PaintFlag {
-		InBubble = 0x01,
+		InBubble = (1 << 0),
-		Selected = 0x02,
+		Selected = (1 << 1),
 	};
 	using PaintFlags = base::flags<PaintFlag>;
 	friend inline constexpr auto is_flag_type(PaintFlag) { return true; };

Telegram/SourceFiles/history/history_widget.h

@@ -691,8 +691,8 @@ private:
 	void countHistoryShowFrom();
 
 	enum class TextUpdateEvent {
-		SaveDraft  = 0x01,
+		SaveDraft  = (1 << 0),
-		SendTyping = 0x02,
+		SendTyping = (1 << 1),
 	};
 	using TextUpdateEvents = base::flags<TextUpdateEvent>;
 	friend inline constexpr auto is_flag_type(TextUpdateEvent) { return true; };

Telegram/SourceFiles/inline_bots/inline_bot_layout_internal.h

@@ -82,8 +82,8 @@ private:
 	QSize countFrameSize() const;
 
 	enum class StateFlag {
-		Over = 0x01,
+		Over       = (1 << 0),
-		DeleteOver = 0x02,
+		DeleteOver = (1 << 1),
 	};
 	using StateFlags = base::flags<StateFlag>;
 	friend inline constexpr auto is_flag_type(StateFlag) { return true; };

Telegram/SourceFiles/observer_peer.h

@@ -35,45 +35,45 @@ struct PeerUpdate {
 	PeerData *peer;
 
 	enum class Flag : uint32 {
-		None                      = 0x00000000U,
+		None                      = 0,
 
 		// Common flags
-		NameChanged               = 0x00000001U,
+		NameChanged               = (1 << 0),
-		UsernameChanged           = 0x00000002U,
+		UsernameChanged           = (1 << 1),
-		PhotoChanged              = 0x00000004U,
+		PhotoChanged              = (1 << 2),
-		AboutChanged              = 0x00000008U,
+		AboutChanged              = (1 << 3),
-		NotificationsEnabled      = 0x00000010U,
+		NotificationsEnabled      = (1 << 4),
-		SharedMediaChanged        = 0x00000020U,
+		SharedMediaChanged        = (1 << 5),
-		MigrationChanged          = 0x00000040U,
+		MigrationChanged          = (1 << 6),
-		PinnedChanged             = 0x00000080U,
+		PinnedChanged             = (1 << 7),
-		RestrictionReasonChanged  = 0x00000100U,
+		RestrictionReasonChanged  = (1 << 8),
 
 		// For chats and channels
-		InviteLinkChanged         = 0x00000200U,
+		InviteLinkChanged         = (1 << 9),
-		MembersChanged            = 0x00000400U,
+		MembersChanged            = (1 << 10),
-		AdminsChanged             = 0x00000800U,
+		AdminsChanged             = (1 << 11),
-		BannedUsersChanged        = 0x00001000U,
+		BannedUsersChanged        = (1 << 12),
-		UnreadMentionsChanged     = 0x00002000U,
+		UnreadMentionsChanged     = (1 << 13),
 
 		// For users
-		UserCanShareContact       = 0x00010000U,
+		UserCanShareContact       = (1 << 16),
-		UserIsContact             = 0x00020000U,
+		UserIsContact             = (1 << 17),
-		UserPhoneChanged          = 0x00040000U,
+		UserPhoneChanged          = (1 << 18),
-		UserIsBlocked             = 0x00080000U,
+		UserIsBlocked             = (1 << 19),
-		BotCommandsChanged        = 0x00100000U,
+		BotCommandsChanged        = (1 << 20),
-		UserOnlineChanged         = 0x00200000U,
+		UserOnlineChanged         = (1 << 21),
-		BotCanAddToGroups         = 0x00400000U,
+		BotCanAddToGroups         = (1 << 22),
-		UserCommonChatsChanged    = 0x00800000U,
+		UserCommonChatsChanged    = (1 << 23),
-		UserHasCalls              = 0x01000000U,
+		UserHasCalls              = (1 << 24),
 
 		// For chats
-		ChatCanEdit               = 0x00010000U,
+		ChatCanEdit               = (1 << 16),
 
 		// For channels
-		ChannelAmIn               = 0x00010000U,
+		ChannelAmIn               = (1 << 16),
-		ChannelRightsChanged      = 0x00020000U,
+		ChannelRightsChanged      = (1 << 17),
-		ChannelStickersChanged    = 0x00040000U,
+		ChannelStickersChanged    = (1 << 18),
-		ChannelPinnedChanged      = 0x00080000U,
+		ChannelPinnedChanged      = (1 << 19),
 	};
 	using Flags = base::flags<Flag>;
 	friend inline constexpr auto is_flag_type(Flag) { return true; }

Telegram/SourceFiles/platform/win/main_window_win.h

@@ -55,11 +55,11 @@ public:
 
 	// Custom shadows.
 	enum class ShadowsChange {
-		Moved    = 0x01,
+		Moved    = (1 << 0),
-		Resized  = 0x02,
+		Resized  = (1 << 1),
-		Shown    = 0x04,
+		Shown    = (1 << 2),
-		Hidden   = 0x08,
+		Hidden   = (1 << 3),
-		Activate = 0x10,
+		Activate = (1 << 4),
 	};
 	using ShadowsChanges = base::flags<ShadowsChange>;
 	friend inline constexpr auto is_flag_type(ShadowsChange) { return true; };

Telegram/SourceFiles/storage/localstorage.cpp

@@ -76,8 +76,8 @@ bool _userWorking() {
 }
 
 enum class FileOption {
-	User = 0x01,
+	User = (1 << 0),
-	Safe = 0x02,
+	Safe = (1 << 1),
 };
 using FileOptions = base::flags<FileOption>;
 inline constexpr auto is_flag_type(FileOption) { return true; };

Telegram/SourceFiles/ui/abstract_button.h

@@ -76,10 +76,10 @@ signals:
 
 protected:
 	enum class StateFlag {
-		None = 0x00,
+		None     = 0,
-		Over = 0x01,
+		Over     = (1 << 0),
-		Down = 0x02,
+		Down     = (1 << 1),
-		Disabled = 0x04,
+		Disabled = (1 << 2),
 	};
 	using State = base::flags<StateFlag>;
 

Telegram/SourceFiles/ui/images.h

@@ -188,18 +188,18 @@ QImage prepareColored(style::color add, QImage image);
 QImage prepareOpaque(QImage image);
 
 enum class Option {
-	None = 0x000,
+	None                  = 0,
-	Smooth = 0x001,
+	Smooth                = (1 << 0),
-	Blurred = 0x002,
+	Blurred               = (1 << 1),
-	Circled = 0x004,
+	Circled               = (1 << 2),
-	RoundedLarge = 0x008,
+	RoundedLarge          = (1 << 3),
-	RoundedSmall = 0x010,
+	RoundedSmall          = (1 << 4),
-	RoundedTopLeft = 0x020,
+	RoundedTopLeft        = (1 << 5),
-	RoundedTopRight = 0x040,
+	RoundedTopRight       = (1 << 6),
-	RoundedBottomLeft = 0x080,
+	RoundedBottomLeft     = (1 << 7),
-	RoundedBottomRight = 0x100,
+	RoundedBottomRight    = (1 << 8),
-	Colored = 0x200,
+	Colored               = (1 << 9),
-	TransparentBackground = 0x400,
+	TransparentBackground = (1 << 10),
 };
 using Options = base::flags<Option>;
 inline constexpr auto is_flag_type(Option) { return true; };

Telegram/SourceFiles/ui/text/text.h

@@ -129,9 +129,9 @@ public:
 
 	struct StateRequest {
 		enum class Flag {
-			BreakEverywhere = 0x01,
+			BreakEverywhere = (1 << 0),
-			LookupSymbol    = 0x02,
+			LookupSymbol    = (1 << 1),
-			LookupLink      = 0x04,
+			LookupLink      = (1 << 2),
 		};
 		using Flags = base::flags<Flag>;
 		friend inline constexpr auto is_flag_type(Flag) { return true; };

Telegram/SourceFiles/ui/twidget.h

@@ -30,34 +30,34 @@ QString GetOverride(const QString &familyName);
 } // namespace
 
 enum class RectPart {
-	None = 0,
+	None        = 0,
 
-	TopLeft = (1 << 0),
+	TopLeft     = (1 << 0),
-	Top = (1 << 1),
+	Top         = (1 << 1),
-	TopRight = (1 << 2),
+	TopRight    = (1 << 2),
-	Left = (1 << 3),
+	Left        = (1 << 3),
-	Center = (1 << 4),
+	Center      = (1 << 4),
-	Right = (1 << 5),
+	Right       = (1 << 5),
-	BottomLeft = (1 << 6),
+	BottomLeft  = (1 << 6),
-	Bottom = (1 << 7),
+	Bottom      = (1 << 7),
 	BottomRight = (1 << 8),
 
-	FullTop = TopLeft | Top | TopRight,
+	FullTop     = TopLeft | Top | TopRight,
 	NoTopBottom = Left | Center | Right,
-	FullBottom = BottomLeft | Bottom | BottomRight,
+	FullBottom  = BottomLeft | Bottom | BottomRight,
-	NoTop = NoTopBottom | FullBottom,
+	NoTop       = NoTopBottom | FullBottom,
-	NoBottom = FullTop | NoTopBottom,
+	NoBottom    = FullTop | NoTopBottom,
 
-	FullLeft = TopLeft | Left | BottomLeft,
+	FullLeft    = TopLeft | Left | BottomLeft,
 	NoLeftRight = Top | Center | Bottom,
-	FullRight = TopRight | Right | BottomRight,
+	FullRight   = TopRight | Right | BottomRight,
-	NoLeft = NoLeftRight | FullRight,
+	NoLeft      = NoLeftRight | FullRight,
-	NoRight = FullLeft | NoLeftRight,
+	NoRight     = FullLeft | NoLeftRight,
 
 	CornersMask = TopLeft | TopRight | BottomLeft | BottomRight,
-	SidesMask = Top | Bottom | Left | Right,
+	SidesMask   = Top | Bottom | Left | Right,
 
-	Full = FullTop | NoTop,
+	Full        = FullTop | NoTop,
 };
 using RectParts = base::flags<RectPart>;
 inline constexpr auto is_flag_type(RectPart) { return true; };

Telegram/SourceFiles/window/window_controller.h

@@ -25,12 +25,12 @@ Copyright (c) 2014-2017 John Preston, https://desktop.telegram.org
 namespace Window {
 
 enum class GifPauseReason {
-	Any = 0,
+	Any           = 0,
 	InlineResults = (1 << 0),
-	SavedGifs = (1 << 1),
+	SavedGifs     = (1 << 1),
-	Layer = (1 << 2),
+	Layer         = (1 << 2),
-	RoundPlaying = (1 << 3),
+	RoundPlaying  = (1 << 3),
-	MediaPreview = (1 << 4),
+	MediaPreview  = (1 << 4),
 };
 using GifPauseReasons = base::flags<GifPauseReason>;
 inline constexpr bool is_flag_type(GifPauseReason) { return true; };