From e6580a5465b92965add41d4c0575d2fc383104d7 Mon Sep 17 00:00:00 2001 From: Berkus Decker Date: Tue, 24 Nov 2020 16:12:42 +0200 Subject: [PATCH] sq misc comments --- nucleus/src/arch/aarch64/objects.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/nucleus/src/arch/aarch64/objects.rs b/nucleus/src/arch/aarch64/objects.rs index c9b152e..7d7807c 100644 --- a/nucleus/src/arch/aarch64/objects.rs +++ b/nucleus/src/arch/aarch64/objects.rs @@ -62,9 +62,8 @@ enum MemoryKind { trait Untyped { // Uses T::SIZE_BITS to properly size the resulting object - // (`where T: KernelObject`) // in some cases size_bits must be passed as argument though... - fn retype(target_cap: CapNodeRootedPath, target_cap_offset: usize, num_objects: usize) -> Result<()>; // @todo return an array of caps? + fn retype(target_cap: CapNodeRootedPath, target_cap_offset: usize, num_objects: usize) -> Result<()>; // @todo return an array of caps? } // MMU @@ -101,8 +100,8 @@ trait VirtSpace { // +--Page -- aka Page +/// Cache data management. trait PageCacheManagement { - // Cache data management. /// Cleans the data cache out to RAM. /// The start and end are relative to the page being serviced. fn clean_data(start_offset: usize, end_offset: usize) -> Result<()>; @@ -125,6 +124,8 @@ trait PageCacheManagement { } // ARM +// mod aarch64 { + struct Page {} impl Page { @@ -221,7 +222,7 @@ trait ASIDControl { // 2. should be easy to map SAS style // 3. should not allocate any memory dynamically // ^ problem with the above API is FrameAllocator -// ^ clients should supply their own memory for frames... +// ^ clients should supply their own memory for frames... from FrameCaps // https://github.com/seL4/seL4_libs/tree/master/libsel4allocman