test+docs(wasm-edge): honest-labeling presence tests + ADR-160 (ADR-159 backlog now TRUE)
- tests/honest_labeling.rs: 10 source-presence tests asserting the A1-A5 claim invariants (disclaimers present, uncited stat removed, WEAPON_ALERT no longer exported, med_* feature-gated, no static-mut event buffers). Each is designed to FAIL on the pre-fix source (ADR-159 A5 manifest-roundtrip style). - ADR-160: records the headline (0 stubs/0 theater, all real DSP -> claim-surface honesty debt), the graded A1-A5 fixes, NO-ACTION positives, per-prefix classification, and the DATA-GATED deferred backlog (criterion benches, per-skill accuracy validation, wasm32 static_mut_refs CI confirmation). - ADR-159: its deferred-backlog line "wasm-edge ... honestly labelled, not claimed" is now actually TRUE. Validation (all 0 failed, host --features std): DEFAULT 615 | MEDICAL (+medical-experimental) 653 | NO-DEFAULT 615; 0 warnings. Co-Authored-By: claude-flow <ruv@ruv.net>
This commit is contained in:
ruv
parent
36af09a4a8
commit
8ad0d0f91c
|
|
@ -202,7 +202,9 @@ Audited and found genuinely correct; cited as positives, not edited:
|
|||
- **Criterion benches** for cog inference latency and `mesh_guard` — ACCEPTED-FUTURE
|
||||
(cold-start timings are recorded in the manifests' `build_metadata`, not yet a
|
||||
regression bench).
|
||||
- **`wasm-edge` 70-skill accuracy** — unvalidated; honestly labelled, not claimed.
|
||||
- **`wasm-edge` skill accuracy** — unvalidated; **now honestly labelled, not
|
||||
claimed** (done in ADR-160: medical/affect/security/exotic claim surfaces
|
||||
disclaimed, renamed, and feature-gated; per-skill accuracy remains DATA-GATED).
|
||||
|
||||
## Consequences
|
||||
|
||||
|
|
|
|||
|
|
@ -0,0 +1,228 @@
|
|||
# ADR-160: Edge Skill Library (`wifi-densepose-wasm-edge`) — Honest Labeling & Soundness Cleanup
|
||||
|
||||
- **Status**: accepted
|
||||
- **Date**: 2026-06-11
|
||||
- **Deciders**: ruv
|
||||
- **Tags**: wasm-edge, esp32, edge-skills, claim-surface, medical-overclaim, affect, prove-everything, soundness, static-mut
|
||||
- **Amends**: ADR-159 (deferred-backlog line for wasm-edge now TRUE)
|
||||
|
||||
## Context
|
||||
|
||||
Beyond-SOTA sweep Milestone 6, over `v2/crates/wifi-densepose-wasm-edge` only,
|
||||
executed under the project's **prove-everything / anti-"AI-slop"** directive.
|
||||
|
||||
### Headline — 0 stubs, 0 theater, all real DSP (REFUTES the slop accusation)
|
||||
|
||||
A read-only audit found this crate has **zero stubs and zero fake-output theater:
|
||||
every one of the ~70 edge skills runs real DSP** (Welford statistics,
|
||||
autocorrelation, DTW, sliced-Wasserstein, ISTA-style recovery, Kalman/HNSW, etc.).
|
||||
The forward paths are genuine signal processing on real CSI-derived inputs. That
|
||||
is the anti-slop win and it is cited here as a positive, not a fabrication.
|
||||
|
||||
What the audit correctly found was **not fake code but an over-confident claim
|
||||
surface**: skill *names* and doc-comments asserting clinical/affective/security
|
||||
capabilities that the **unvalidated** code cannot back, concentrated in the
|
||||
medical (`med_*`) and affect (`exo_happiness`/`exo_emotion`) skills. The fix is
|
||||
**honest labeling — making the labels TRUE — NOT making the claimed capability
|
||||
real.** You cannot validate seizure detection, affect inference, or weapon
|
||||
discrimination without clinical/labelled data and reference standards; this ADR
|
||||
does not pretend to. It disclaims, renames, softens, and feature-gates so the
|
||||
surface matches what the DSP actually delivers.
|
||||
|
||||
Grading vocabulary follows ADR-152 / ADR-158 / ADR-159:
|
||||
- **MEASURED** — reproduced in this worktree, command + failing-on-old test recorded.
|
||||
- **DATA-GATED** — real code path present; honestly flagged where data is absent.
|
||||
- **NO-ACTION (already-honest)** — audited, found correct, cited as a positive.
|
||||
- **ACCEPTED-FUTURE** — deliberately deferred, nothing dropped.
|
||||
|
||||
## Per-prefix classification
|
||||
|
||||
| Prefix | Class | Note |
|
||||
|--------|-------|------|
|
||||
| `sig_*` (signal intelligence) | **REAL-DSP, honest** | Algorithm-named (flash-attention, sparse-recovery, optimal-transport, temporal-compress, mincut). Names describe the math, not an overclaimed outcome. NO-ACTION on labels; A5 soundness applied. |
|
||||
| `lrn_*` (adaptive learning) | **REAL-DSP, honest** | DTW/EWC/meta-adapt/attractor — algorithm-named. NO-ACTION on labels; A5 applied. |
|
||||
| `spt_*` / `tmp_*` | **REAL-DSP, honest** | PageRank/HNSW/spiking-tracker; LTL-guard/GOAP/pattern-sequence. Algorithm-named. NO-ACTION on labels; A5 applied. |
|
||||
| `qnt_*` | **REAL-DSP, honest (disclosed analogy)** | "quantum-**inspired**" / Grover-**inspired** are already disclosed analogies. NO-ACTION (DO-NOT-touch); A5 applied (mechanical, no label/behavior change). |
|
||||
| `bld_*` / `ret_*` / `ind_*` / `occupancy`/`intrusion` | **REAL-DSP, honest** | Occupancy/queue/forklift/clean-room etc. describe physical observables. NO-ACTION on labels; A5 applied. |
|
||||
| `sec_weapon_detect` | **REAL-DSP, overclaiming NAME** → fixed (A3) | Variance-ratio reflectivity renamed off "weapon". |
|
||||
| `med_*` (5) | **REAL-DSP, overclaiming NAME/DOC** → fixed (A1) | Clinical detection asserted as fact; now disclaimed + softened + feature-gated. |
|
||||
| `exo_happiness` / `exo_emotion` | **REAL-DSP, overclaiming NAME/DOC** → fixed (A2) | Affect outputs reframed as proxies; uncited stat removed. |
|
||||
| `exo_dream_stage` / `exo_gesture_language` | **REAL-DSP, quasi-medical/over-named** → fixed (A4) | Disclaimers added; Research tag promoted to header. |
|
||||
| `exo_time_crystal` / `exo_ghost_hunter` | **REAL-DSP, honest novelty** | Disclosed exploratory/novelty skills. NO-ACTION (DO-NOT-touch); A5 applied. |
|
||||
| `nvsim` | out of scope | Disclaimer gold standard; copied its tone. |
|
||||
|
||||
## Decision — Fixes Landed
|
||||
|
||||
### §A1 Medical overclaim (HIGH) — MEASURED
|
||||
|
||||
The five `med_*` modules (`med_seizure_detect`, `med_cardiac_arrhythmia`,
|
||||
`med_respiratory_distress`, `med_sleep_apnea`, `med_gait_analysis`) stated clinical
|
||||
detection as fact with no disclaimer ("Detects tonic-clonic seizures…").
|
||||
|
||||
**Real fix (honest labeling — the DSP is kept, untouched):**
|
||||
- **(a)** Every module's `//!` header now carries a mandatory disclaimer block,
|
||||
modelled on `sec_weapon_detect.rs` and `nvsim/src/lib.rs`: *"EXPERIMENTAL
|
||||
RESEARCH MODULE — NOT VALIDATED AGAINST CLINICAL DATA. NOT A MEDICAL DEVICE.
|
||||
Flags candidate <X>-like signatures only,"* citing ADR-160.
|
||||
- **(b)** Doc verbs softened: *"Detects tonic-clonic seizures"* →
|
||||
*"Flags candidate tonic-clonic-seizure-like motion signatures (experimental)"*;
|
||||
similarly for cardiac/respiratory/apnea/gait.
|
||||
- **(c)** All five gated behind a new **non-default** cargo feature
|
||||
`medical-experimental` (`#[cfg(feature = "medical-experimental")]` in `lib.rs`,
|
||||
`medical-experimental = []` in `Cargo.toml`, **not** in `default`) so they cannot
|
||||
be silently built into a shipping artifact.
|
||||
|
||||
**Failing-on-old tests** (`tests/honest_labeling.rs`):
|
||||
`a1_med_modules_have_clinical_disclaimer`,
|
||||
`a1_med_modules_gated_behind_medical_experimental`,
|
||||
`a1_seizure_verbs_softened`. All fail on the old, undisclaimed, ungated source.
|
||||
**Grade: MEASURED (label); per-skill clinical accuracy DATA-GATED.**
|
||||
|
||||
### §A2 Affect overclaim (HIGH) — MEASURED
|
||||
|
||||
`exo_happiness_score.rs` carried an **uncited** "Happy people walk ~12% faster"
|
||||
statistic and emits `HAPPINESS_SCORE`; `exo_emotion_detect.rs` emits
|
||||
`STRESS_INDEX`/`CALM_DETECTED`/`AGITATION_DETECTED`.
|
||||
|
||||
**Real fix (honest labeling — math kept):**
|
||||
- Deleted the uncited "12% faster" / "~12% above" / "Happy people walk" statements.
|
||||
- Added a prominent *"speculative, unvalidated affect heuristic; outputs are NOT
|
||||
measurements of emotion"* disclaimer to both `//!` headers, citing ADR-160.
|
||||
- Reframed `HAPPINESS_SCORE` in the docs as a **"gait-energy proxy, not a validated
|
||||
affect measure."**
|
||||
|
||||
**Failing-on-old tests:** `a2_affect_modules_have_unvalidated_disclaimer`,
|
||||
`a2_uncited_12_percent_stat_removed`, `a2_happiness_reframed_as_proxy`.
|
||||
**Grade: MEASURED (label); affect validity DATA-GATED.**
|
||||
|
||||
### §A3 Security event-name overclaim (MEDIUM) — MEASURED
|
||||
|
||||
`sec_weapon_detect.rs`'s module doc was already honest (research-grade,
|
||||
calibration-required), but the event/const names claimed weapon-grade
|
||||
discrimination a variance ratio cannot deliver.
|
||||
|
||||
**Real fix (honest physical-quantity naming — behavior unchanged):**
|
||||
- `EVENT_WEAPON_ALERT` → `EVENT_HIGH_METAL_REFLECTIVITY` (event id 221 unchanged).
|
||||
- `WEAPON_RATIO_THRESH` → `HIGH_REFLECTIVITY_THRESH`.
|
||||
- Internal fields/consts renamed (`weapon_run`→`high_refl_run`,
|
||||
`cd_weapon`→`cd_high_refl`, `WEAPON_DEBOUNCE`→`HIGH_REFLECTIVITY_DEBOUNCE`).
|
||||
- `lib.rs` `event_types` registry: `WEAPON_ALERT` → `HIGH_METAL_REFLECTIVITY`.
|
||||
- A reflectivity-vs-weapons honest-naming note added to the header.
|
||||
The detector still flags a high amplitude-variance/phase-variance ratio (real RF
|
||||
reflectivity); it just no longer *names* that "weapon".
|
||||
|
||||
**Failing-on-old tests:** `a3_weapon_names_renamed_to_reflectivity`,
|
||||
`a3_registry_no_longer_exports_weapon_alert` (registry no longer exports a
|
||||
`WEAPON_ALERT` name). **Grade: MEASURED.**
|
||||
|
||||
### §A4 Quasi-medical / sign-language exotic modules (MEDIUM) — MEASURED
|
||||
|
||||
`exo_dream_stage.rs` ("sleep stage classification", quasi-medical) and
|
||||
`exo_gesture_language.rs` ("sign language letter recognition").
|
||||
|
||||
**Real fix (honest labeling — DSP kept):** added an experimental "NOT VALIDATED"
|
||||
disclaimer to each `//!` header (citing ADR-160) and promoted the
|
||||
**Exotic/Research** registry tag into the header where a reader sees it.
|
||||
`exo_gesture_language` additionally states it is a coarse gesture-cluster
|
||||
classifier that **does not recognize true sign language** (never evaluated on a
|
||||
labelled ASL set).
|
||||
|
||||
**Failing-on-old test:** `a4_exotic_modules_have_experimental_disclaimer`.
|
||||
**Grade: MEASURED (label); accuracy DATA-GATED.**
|
||||
|
||||
### §A5 `static mut` event-buffer soundness (MEDIUM) — the one real code fix — MEASURED
|
||||
|
||||
~61 per-call event scratch buffers across the crate used a module-level
|
||||
`static mut EVENTS: [(i32,f32); N]` (a handful named `EV`/`TE`/`EMPTY`) and returned
|
||||
`&EVENTS[..n]`. On a `cdylib`+`rlib` linkable into multithreaded/reentrant host
|
||||
code this is latent aliasing UB, and `static_mut_refs` is deny-by-default on newer
|
||||
Rust.
|
||||
|
||||
**Real fix (mechanical, behavior-preserving):** moved each scratch buffer off
|
||||
`static mut` into an **owned per-instance field** (`events: [(i32,f32); N]` on the
|
||||
detector struct, written via `&mut self` and returned as `&self.events[..n]`). The
|
||||
public `-> &[(i32, f32)]` signature is **unchanged**, so no caller (in-module
|
||||
tests, `ghost_hunter` bin, `budget_compliance`) needed editing. Two helper methods
|
||||
that built events under `&self` (`spt_pagerank_influence::build_events`,
|
||||
`spt_spiking_tracker::build_events`) and `sig_temporal_compress::on_timer` were
|
||||
promoted to `&mut self`. Leftover now-redundant `unsafe { }` wrappers were removed.
|
||||
|
||||
**Count: 61 scratch buffers across 60 module files fixed** (the only `static mut`
|
||||
left in `src/` are the two **legitimate WASM module singletons** — `lib.rs STATE`
|
||||
and `bin/ghost_hunter.rs DETECTOR` — `#[cfg(target_arch="wasm32")]`,
|
||||
`#[no_mangle]`, accessed via `core::ptr::addr_of_mut!`, single-threaded by the
|
||||
wasm runtime contract; these are *not* the aliasing-UB scratch pattern and are
|
||||
left as-is).
|
||||
|
||||
**Verification:** the full host build (`--features std` and
|
||||
`std,medical-experimental`) compiles with **0 warnings** — there is no longer any
|
||||
`static mut <name>` + `&<name>` source for `static_mut_refs` to fire on in the 60
|
||||
fixed modules. (The pure-`wasm32-unknown-unknown` build, where the lint is
|
||||
deny-by-default, could not be run in this worktree because the `wasm32` target is
|
||||
not installed on the build toolchain; the source-level elimination is the
|
||||
evidence, asserted per-module by `a5_claim_bearing_modules_have_no_static_mut_event_buffer`.)
|
||||
**Grade: MEASURED (source-eliminated; residual = 2 legitimate singletons).**
|
||||
|
||||
## Negative Results (NO-ACTION positives — cited, not edited for labels)
|
||||
|
||||
Audited and found genuinely honest; cited as positives:
|
||||
- **`qnt_quantum_coherence.rs`** — discloses "quantum-**inspired**" analogy.
|
||||
- **`exo_time_crystal.rs`**, **`exo_ghost_hunter.rs`** — disclosed exploratory/novelty.
|
||||
- **`qnt_interference_search.rs`** — disclosed "Grover-**inspired**".
|
||||
- **`sig_*` / `lrn_*`** algorithm-named skills — names describe the DSP, not an outcome.
|
||||
- **`nvsim`** — out of scope; the project's disclaimer gold standard (its tone was
|
||||
copied into the A1/A2/A4 disclaimers).
|
||||
|
||||
(These were A5-soundness-fixed mechanically where they used `static mut`, with no
|
||||
label or behavior change, consistent with leaving their claim surface intact.)
|
||||
|
||||
## Deferred Backlog (Nothing Dropped)
|
||||
|
||||
- **Per-skill accuracy validation** — **DATA-GATED**. Validating any med_*/affect/
|
||||
sign-language claim requires labelled clinical/affective/ASL data and reference
|
||||
standards that do not exist in this repo. The disclaimers + feature gate are the
|
||||
honest stand-in. Nothing is claimed that is not measured.
|
||||
- **Criterion benches for `process_frame` budget claims** — **ACCEPTED-FUTURE**.
|
||||
`tests/budget_compliance.rs` asserts L/S/H tier wall-clock budgets (25 tests,
|
||||
passing), but a regression-grade criterion bench is not yet wired.
|
||||
- **`wasm32-unknown-unknown` `static_mut_refs` confirmation** — **ACCEPTED-FUTURE**
|
||||
(toolchain): the source pattern is eliminated; a CI job on the wasm target should
|
||||
assert zero `static_mut_refs` once the target is added to the build image.
|
||||
- **The 2 residual `static mut` singletons** (`lib.rs STATE`, `ghost_hunter DETECTOR`)
|
||||
— **ACCEPTED-FUTURE**: these are the canonical wasm module-state pattern; migrating
|
||||
them to a safe cell is a separate, larger change with no current UB (single-threaded
|
||||
wasm runtime, `addr_of_mut!` access).
|
||||
|
||||
## Reproduction (MEASURED)
|
||||
|
||||
```bash
|
||||
cd v2/crates/wifi-densepose-wasm-edge # excluded from the v2 workspace; build here
|
||||
cargo test --features std # default
|
||||
cargo test --features std,medical-experimental # med_* skills enabled
|
||||
cargo test --no-default-features --features std # no default-pipeline
|
||||
cargo test --features std --test honest_labeling # A1–A5 label invariants
|
||||
```
|
||||
|
||||
(`std` is required for host tests — the crate is `no_std` for `wasm32`; pure
|
||||
`--no-default-features` builds only on `wasm32-unknown-unknown`, where it
|
||||
intentionally has no panic handler on the host.)
|
||||
|
||||
Result at time of writing (all 0 failed):
|
||||
- **DEFAULT** (`--features std`) — **615 passed** (lib 504; budget 25; honest_labeling 10; bench 1; vendor 75)
|
||||
- **MEDICAL** (`--features std,medical-experimental`) — **653 passed** (lib 542; +38 med_* tests; others unchanged)
|
||||
- **NO-DEFAULT** (`--no-default-features --features std`) — **615 passed**
|
||||
- Full host build emits **0 warnings**; **61** `static mut` scratch buffers eliminated, **2** legitimate wasm singletons remain.
|
||||
|
||||
## Consequences
|
||||
|
||||
- No edge skill's name or doc-comment claims a clinical, affective, security, or
|
||||
sign-language capability the unvalidated DSP cannot back.
|
||||
- The five medical skills cannot be silently compiled into a shipping artifact
|
||||
(non-default `medical-experimental` gate).
|
||||
- The security skill can never emit a "weapon alert" — it reports
|
||||
`HIGH_METAL_REFLECTIVITY`, the physical quantity it actually measures.
|
||||
- The latent `static mut` aliasing-UB / `static_mut_refs` exposure is removed from
|
||||
60 modules; the public API and all runtime behavior are unchanged (615/653 tests
|
||||
prove behavior preservation).
|
||||
- ADR-159's deferred-backlog statement *"wasm-edge … honestly labelled, not
|
||||
claimed"* is now actually TRUE.
|
||||
|
|
@ -0,0 +1,259 @@
|
|||
//! Honest-labeling source-presence tests (ADR-160).
|
||||
//!
|
||||
//! These tests assert that the claim-surface fixes A1–A4 are physically present
|
||||
//! in the source (disclaimers added, uncited stats removed, overclaiming names
|
||||
//! renamed). They are deliberately source-text assertions (`include_str!`),
|
||||
//! mirroring ADR-159 §A5 / `cog-pose-estimation`'s `manifest_roundtrips` pattern:
|
||||
//! the win here is making the *labels* true, which is a documentation invariant,
|
||||
//! not a runtime capability. Each test is designed to FAIL on the pre-fix source.
|
||||
|
||||
// ── A1: medical modules carry the mandatory disclaimer + feature gate ─────────
|
||||
|
||||
const MED_SEIZURE: &str = include_str!("../src/med_seizure_detect.rs");
|
||||
const MED_CARDIAC: &str = include_str!("../src/med_cardiac_arrhythmia.rs");
|
||||
const MED_RESP: &str = include_str!("../src/med_respiratory_distress.rs");
|
||||
const MED_APNEA: &str = include_str!("../src/med_sleep_apnea.rs");
|
||||
const MED_GAIT: &str = include_str!("../src/med_gait_analysis.rs");
|
||||
|
||||
const MED_MODULES: &[(&str, &str)] = &[
|
||||
("med_seizure_detect", MED_SEIZURE),
|
||||
("med_cardiac_arrhythmia", MED_CARDIAC),
|
||||
("med_respiratory_distress", MED_RESP),
|
||||
("med_sleep_apnea", MED_APNEA),
|
||||
("med_gait_analysis", MED_GAIT),
|
||||
];
|
||||
|
||||
|
||||
/// Char-boundary-safe prefix of up to `max` bytes (module headers are ASCII-ish
|
||||
/// but contain box-drawing chars, so a naive byte slice can split a UTF-8 char).
|
||||
fn char_safe_prefix(s: &str, max: usize) -> &str {
|
||||
let mut end = s.len().min(max);
|
||||
while end > 0 && !s.is_char_boundary(end) { end -= 1; }
|
||||
&s[..end]
|
||||
}
|
||||
|
||||
/// A1(a): every med_* module's `//!` header must carry the mandatory disclaimer
|
||||
/// stating it is experimental, not clinically validated, and not a medical device.
|
||||
#[test]
|
||||
fn a1_med_modules_have_clinical_disclaimer() {
|
||||
for (name, src) in MED_MODULES {
|
||||
// Search the whole module doc-comment region (first ~2KB) for robustness.
|
||||
let scan = char_safe_prefix(src, 2048);
|
||||
assert!(
|
||||
scan.contains("NOT VALIDATED AGAINST CLINICAL DATA"),
|
||||
"{name}: missing 'NOT VALIDATED AGAINST CLINICAL DATA' disclaimer"
|
||||
);
|
||||
assert!(
|
||||
scan.contains("NOT A MEDICAL DEVICE"),
|
||||
"{name}: missing 'NOT A MEDICAL DEVICE' disclaimer"
|
||||
);
|
||||
assert!(
|
||||
scan.contains("EXPERIMENTAL"),
|
||||
"{name}: missing 'EXPERIMENTAL' marker"
|
||||
);
|
||||
// ADR cross-reference so the disclaimer is traceable.
|
||||
assert!(
|
||||
scan.contains("ADR-160"),
|
||||
"{name}: disclaimer should cite ADR-160"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
/// A1(c): all five med_* modules must be gated behind the non-default
|
||||
/// `medical-experimental` cargo feature in lib.rs (cannot be silently shipped).
|
||||
#[test]
|
||||
fn a1_med_modules_gated_behind_medical_experimental() {
|
||||
const LIB: &str = include_str!("../src/lib.rs");
|
||||
for (name, _) in MED_MODULES {
|
||||
// Each module declaration must be immediately preceded by the cfg gate.
|
||||
let decl = format!("pub mod {name};");
|
||||
let idx = LIB
|
||||
.find(&decl)
|
||||
.unwrap_or_else(|| panic!("{name}: `{decl}` not found in lib.rs"));
|
||||
let preceding = &LIB[idx.saturating_sub(80)..idx];
|
||||
assert!(
|
||||
preceding.contains("#[cfg(feature = \"medical-experimental\")]"),
|
||||
"{name}: `{decl}` not gated behind medical-experimental in lib.rs"
|
||||
);
|
||||
}
|
||||
// The feature itself must exist in Cargo.toml.
|
||||
const CARGO: &str = include_str!("../Cargo.toml");
|
||||
assert!(
|
||||
CARGO.contains("medical-experimental = []"),
|
||||
"Cargo.toml missing `medical-experimental` feature definition"
|
||||
);
|
||||
// And it must NOT be in the default feature set.
|
||||
let default_line = CARGO
|
||||
.lines()
|
||||
.find(|l| l.trim_start().starts_with("default = ["))
|
||||
.expect("Cargo.toml missing default features");
|
||||
assert!(
|
||||
!default_line.contains("medical-experimental"),
|
||||
"medical-experimental must be NON-default; found in: {default_line}"
|
||||
);
|
||||
}
|
||||
|
||||
/// A1(b): the seizure module must no longer assert detection as fact
|
||||
/// ("Detects tonic-clonic seizures") and must use softened "candidate"/"flags"
|
||||
/// language instead.
|
||||
#[test]
|
||||
fn a1_seizure_verbs_softened() {
|
||||
assert!(
|
||||
!MED_SEIZURE.contains("Detects tonic-clonic seizures"),
|
||||
"med_seizure_detect still asserts 'Detects tonic-clonic seizures' as fact"
|
||||
);
|
||||
assert!(
|
||||
MED_SEIZURE.contains("candidate") && MED_SEIZURE.contains("signature"),
|
||||
"med_seizure_detect should describe 'candidate ... signatures' (experimental)"
|
||||
);
|
||||
}
|
||||
|
||||
// ── A2: affect modules carry the speculative/unvalidated disclaimer ───────────
|
||||
|
||||
const EXO_HAPPINESS: &str = include_str!("../src/exo_happiness_score.rs");
|
||||
const EXO_EMOTION: &str = include_str!("../src/exo_emotion_detect.rs");
|
||||
|
||||
/// A2: both affect modules must declare outputs are NOT measurements of emotion
|
||||
/// and cite ADR-160.
|
||||
#[test]
|
||||
fn a2_affect_modules_have_unvalidated_disclaimer() {
|
||||
for (name, src) in [("exo_happiness_score", EXO_HAPPINESS), ("exo_emotion_detect", EXO_EMOTION)] {
|
||||
let scan = char_safe_prefix(src, 2048);
|
||||
assert!(
|
||||
scan.contains("NOT measurements of emotion") || scan.contains("NOT a")
|
||||
&& scan.contains("affect"),
|
||||
"{name}: missing 'NOT measurements of emotion' style disclaimer"
|
||||
);
|
||||
assert!(
|
||||
scan.to_lowercase().contains("speculative")
|
||||
|| scan.to_lowercase().contains("unvalidated"),
|
||||
"{name}: missing speculative/unvalidated qualifier"
|
||||
);
|
||||
assert!(scan.contains("ADR-160"), "{name}: disclaimer should cite ADR-160");
|
||||
}
|
||||
}
|
||||
|
||||
/// A2: the uncited "Happy people walk ~12% faster" statistic must be deleted.
|
||||
#[test]
|
||||
fn a2_uncited_12_percent_stat_removed() {
|
||||
assert!(
|
||||
!EXO_HAPPINESS.contains("12% faster"),
|
||||
"exo_happiness_score still contains the uncited '12% faster' claim"
|
||||
);
|
||||
assert!(
|
||||
!EXO_HAPPINESS.contains("~12% above"),
|
||||
"exo_happiness_score still contains the uncited '~12% above' claim"
|
||||
);
|
||||
assert!(
|
||||
!EXO_HAPPINESS.contains("Happy people walk"),
|
||||
"exo_happiness_score still contains the uncited 'Happy people walk' claim"
|
||||
);
|
||||
}
|
||||
|
||||
/// A2: HAPPINESS_SCORE must be documented as a gait-energy proxy, not an affect
|
||||
/// measurement.
|
||||
#[test]
|
||||
fn a2_happiness_reframed_as_proxy() {
|
||||
assert!(
|
||||
EXO_HAPPINESS.contains("gait-energy proxy"),
|
||||
"exo_happiness_score should document HAPPINESS_SCORE as a 'gait-energy proxy'"
|
||||
);
|
||||
}
|
||||
|
||||
// ── A3: weapon-detect renamed to honest physical quantities ───────────────────
|
||||
|
||||
const SEC_WEAPON: &str = include_str!("../src/sec_weapon_detect.rs");
|
||||
const LIB_RS: &str = include_str!("../src/lib.rs");
|
||||
|
||||
/// A3: the weapon-grade overclaim must be gone from the event/const names.
|
||||
#[test]
|
||||
fn a3_weapon_names_renamed_to_reflectivity() {
|
||||
// The module must no longer *define* a WEAPON_ALERT event or WEAPON_RATIO_THRESH
|
||||
// const. (A doc-comment may still reference the old name historically, e.g.
|
||||
// "formerly `EVENT_WEAPON_ALERT`" — we assert on the definitions, not mentions.)
|
||||
assert!(
|
||||
!SEC_WEAPON.contains("pub const EVENT_WEAPON_ALERT"),
|
||||
"sec_weapon_detect still defines/exports EVENT_WEAPON_ALERT"
|
||||
);
|
||||
assert!(
|
||||
!SEC_WEAPON.contains("const WEAPON_RATIO_THRESH"),
|
||||
"sec_weapon_detect still defines WEAPON_RATIO_THRESH"
|
||||
);
|
||||
// Honest replacements must be present.
|
||||
assert!(
|
||||
SEC_WEAPON.contains("EVENT_HIGH_METAL_REFLECTIVITY"),
|
||||
"sec_weapon_detect missing renamed EVENT_HIGH_METAL_REFLECTIVITY"
|
||||
);
|
||||
assert!(
|
||||
SEC_WEAPON.contains("HIGH_REFLECTIVITY_THRESH"),
|
||||
"sec_weapon_detect missing renamed HIGH_REFLECTIVITY_THRESH"
|
||||
);
|
||||
}
|
||||
|
||||
/// A3: the lib.rs event registry must no longer export a `WEAPON_ALERT` name.
|
||||
#[test]
|
||||
fn a3_registry_no_longer_exports_weapon_alert() {
|
||||
assert!(
|
||||
!LIB_RS.contains("pub const WEAPON_ALERT"),
|
||||
"event_types registry still exports WEAPON_ALERT"
|
||||
);
|
||||
assert!(
|
||||
LIB_RS.contains("pub const HIGH_METAL_REFLECTIVITY"),
|
||||
"event_types registry missing HIGH_METAL_REFLECTIVITY (id 221)"
|
||||
);
|
||||
}
|
||||
|
||||
// ── A4: quasi-medical / sign-language exotic modules carry the disclaimer ──────
|
||||
|
||||
const EXO_DREAM: &str = include_str!("../src/exo_dream_stage.rs");
|
||||
const EXO_SIGN: &str = include_str!("../src/exo_gesture_language.rs");
|
||||
|
||||
/// A4: dream-stage and gesture-language modules promote the Exotic/Research tag
|
||||
/// into a header disclaimer and state they are not validated.
|
||||
#[test]
|
||||
fn a4_exotic_modules_have_experimental_disclaimer() {
|
||||
for (name, src) in [("exo_dream_stage", EXO_DREAM), ("exo_gesture_language", EXO_SIGN)] {
|
||||
let scan = char_safe_prefix(src, 2048);
|
||||
assert!(
|
||||
scan.contains("EXPERIMENTAL") && scan.contains("NOT VALIDATED"),
|
||||
"{name}: missing EXPERIMENTAL / NOT VALIDATED disclaimer"
|
||||
);
|
||||
assert!(scan.contains("ADR-160"), "{name}: disclaimer should cite ADR-160");
|
||||
assert!(
|
||||
scan.contains("Research"),
|
||||
"{name}: should surface the Exotic/Research registry tag in the header"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
// ── A5: the static_mut soundness fix is present (no per-call static mut bufs) ──
|
||||
|
||||
/// A5: claim-bearing modules must no longer use a `static mut` event scratch
|
||||
/// buffer (latent aliasing UB). They now own a per-instance `events` field.
|
||||
#[test]
|
||||
fn a5_claim_bearing_modules_have_no_static_mut_event_buffer() {
|
||||
let modules: &[(&str, &str)] = &[
|
||||
("med_seizure_detect", MED_SEIZURE),
|
||||
("med_cardiac_arrhythmia", MED_CARDIAC),
|
||||
("med_respiratory_distress", MED_RESP),
|
||||
("med_sleep_apnea", MED_APNEA),
|
||||
("med_gait_analysis", MED_GAIT),
|
||||
("exo_happiness_score", EXO_HAPPINESS),
|
||||
("exo_emotion_detect", EXO_EMOTION),
|
||||
("sec_weapon_detect", SEC_WEAPON),
|
||||
("exo_dream_stage", EXO_DREAM),
|
||||
("exo_gesture_language", EXO_SIGN),
|
||||
];
|
||||
for (name, src) in modules {
|
||||
assert!(
|
||||
!src.contains("static mut EVENTS")
|
||||
&& !src.contains("static mut EV:")
|
||||
&& !src.contains("static mut EMPTY"),
|
||||
"{name}: still uses a `static mut` event scratch buffer (A5 not applied)"
|
||||
);
|
||||
assert!(
|
||||
src.contains("events: [(i32, f32);"),
|
||||
"{name}: missing owned `events` scratch buffer field (A5)"
|
||||
);
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue