From 41aeb97c16fdee1b249e86240c739c567e162d4e Mon Sep 17 00:00:00 2001 From: Alain Emilia Anna Zscheile Date: Wed, 11 Dec 2024 23:11:35 +0100 Subject: [PATCH] fix(geometry/rwr): Fix missing pads due to buggy `add_to_compound` The origin of this bug was found via git-bisect, commit d6fe67a373ff1802b4e289571c1ee853dd064993 is buggy, which switches from GeometryWithRtree to RecordingGeometryWithRtree. In PR #128, it was discovered that `add_to_compound` appears to be missing the part that actually invokes the function that performs the underlying action that is supposed to be diffed. Fixes #127 --- src/geometry/recording_with_rtree.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/geometry/recording_with_rtree.rs b/src/geometry/recording_with_rtree.rs index 78e9263..9179464 100644 --- a/src/geometry/recording_with_rtree.rs +++ b/src/geometry/recording_with_rtree.rs @@ -149,7 +149,7 @@ impl< let old_members = geometry.compound_members(compound).collect(); let old_weight = geometry.compound_weight(compound); - // TODO ??? + self.geometry_with_rtree.add_to_compound(primitive, compound); let geometry = self.geometry_with_rtree.geometry(); let new_members = geometry.compound_members(compound).collect();