feat: improve Selection API (BREAKS HISTORY)

Test command files were rewritten using:

```
for f in tests/**/*.cmd; do jq ".done?.[].Autoroute[0] |= .selectors" "$f" | sponge "$f"; done
```
(compatible with bash/zsh/...)

src/autorouter/selection.rs

@@ -16,32 +16,8 @@ pub struct PinSelector {
     pub layer: String,
 }
 
-#[derive(Debug, Default, Clone, Serialize, Deserialize)]
+impl PinSelector {
-pub struct PinSelection {
+    pub fn try_from_node(
-    selectors: HashSet<PinSelector>,
-}
-
-impl PinSelection {
-    pub fn new() -> Self {
-        Self::default()
-    }
-
-    pub fn new_select_layer(board: &Board<impl AccessMesadata>, layer: usize) -> Self {
-        let mut this = Self::new();
-
-        for node in board.layout().drawing().layer_primitive_nodes(layer) {
-            if let Some(selector) = this.node_selector(board, GenericNode::Primitive(node)) {
-                if !this.contains_node(board, GenericNode::Primitive(node)) {
-                    this.select(selector);
-                }
-            }
-        }
-
-        this
-    }
-
-    fn node_selector(
-        &self,
         board: &Board<impl AccessMesadata>,
         node: NodeIndex,
     ) -> Option<PinSelector> {
@@ -74,22 +50,35 @@ impl PinSelection {
             None
         }
     }
+}
 
-    fn select(&mut self, selector: PinSelector) {
+#[derive(Debug, Default, Clone, Serialize, Deserialize)]
-        self.selectors.insert(selector);
+pub struct PinSelection(HashSet<PinSelector>);
+
+impl PinSelection {
+    pub fn new() -> Self {
+        Self::default()
     }
 
-    fn deselect(&mut self, selector: &PinSelector) {
+    pub fn new_select_layer(board: &Board<impl AccessMesadata>, layer: usize) -> Self {
-        self.selectors.remove(selector);
+        let mut this = Self::default();
+
+        for node in board.layout().drawing().layer_primitive_nodes(layer) {
+            if let Some(selector) = PinSelector::try_from_node(board, GenericNode::Primitive(node))
+            {
+                this.0.insert(selector);
+            }
+        }
+
+        this
     }
 
     pub fn contains_node(&self, board: &Board<impl AccessMesadata>, node: NodeIndex) -> bool {
-        self.node_selector(board, node)
+        PinSelector::try_from_node(board, node).map_or(false, |selector| self.0.contains(&selector))
-            .map_or(false, |selector| self.selectors.contains(&selector))
     }
 
     pub fn selectors(&self) -> impl Iterator<Item = &PinSelector> {
-        self.selectors.iter()
+        self.0.iter()
     }
 }
 
@@ -98,18 +87,8 @@ pub struct BandSelector {
     pub band: BandName,
 }
 
-#[derive(Debug, Default, Clone, Serialize, Deserialize)]
+impl BandSelector {
-pub struct BandSelection {
+    pub fn try_from_node(
-    selectors: HashSet<BandSelector>,
-}
-
-impl BandSelection {
-    pub fn new() -> Self {
-        Self::default()
-    }
-
-    fn node_selector(
-        &self,
         board: &Board<impl AccessMesadata>,
         node: NodeIndex,
     ) -> Option<BandSelector> {
@@ -131,22 +110,23 @@ impl BandSelection {
                 .clone(),
         })
     }
+}
 
-    fn select(&mut self, selector: BandSelector) {
+#[derive(Debug, Default, Clone, Serialize, Deserialize)]
-        self.selectors.insert(selector);
+pub struct BandSelection(HashSet<BandSelector>);
-    }
 
-    fn deselect(&mut self, selector: &BandSelector) {
+impl BandSelection {
-        self.selectors.remove(selector);
+    pub fn new() -> Self {
+        Self::default()
     }
 
     pub fn contains_node(&self, board: &Board<impl AccessMesadata>, node: NodeIndex) -> bool {
-        self.node_selector(board, node)
+        BandSelector::try_from_node(board, node)
-            .map_or(false, |selector| self.selectors.contains(&selector))
+            .map_or(false, |selector| self.0.contains(&selector))
     }
 
     pub fn selectors(&self) -> impl Iterator<Item = &BandSelector> {
-        self.selectors.iter()
+        self.0.iter()
     }
 }
 
@@ -162,17 +142,17 @@ impl Selection {
     }
 
     pub fn toggle_at_node(&mut self, board: &Board<impl AccessMesadata>, node: NodeIndex) {
-        if let Some(selector) = self.pin_selection.node_selector(board, node) {
+        if let Some(selector) = PinSelector::try_from_node(board, node) {
-            if self.pin_selection.contains_node(board, node) {
+            if self.pin_selection.0.contains(&selector) {
-                self.pin_selection.deselect(&selector);
+                self.pin_selection.0.remove(&selector);
             } else {
-                self.pin_selection.select(selector);
+                self.pin_selection.0.insert(selector);
             }
-        } else if let Some(selector) = self.band_selection.node_selector(board, node) {
+        } else if let Some(selector) = BandSelector::try_from_node(board, node) {
-            if self.band_selection.contains_node(board, node) {
+            if self.band_selection.0.contains(&selector) {
-                self.band_selection.deselect(&selector);
+                self.band_selection.0.remove(&selector);
             } else {
-                self.band_selection.select(selector);
+                self.band_selection.0.insert(selector);
             }
         }
     }

tests/single_layer/0603_breakout/autoroute_all.cmd

@@ -2,8 +2,7 @@
   "done": [
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "R1-2",
             "layer": "F.Cu"
@@ -12,8 +11,7 @@
             "pin": "J1-2",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {
@@ -26,8 +24,7 @@
     },
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "J1-1",
             "layer": "F.Cu"
@@ -36,8 +33,7 @@
             "pin": "R1-1",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {

tests/single_layer/4x_3rd_order_smd_lc_filters/autoroute_signals.cmd

@@ -2,8 +2,7 @@
   "done": [
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "L3-1",
             "layer": "F.Cu"
@@ -48,8 +47,7 @@
             "pin": "L2-1",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {
@@ -62,8 +60,7 @@
     },
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "C6-1",
             "layer": "F.Cu"
@@ -108,8 +105,7 @@
             "pin": "L4-2",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {
@@ -122,8 +118,7 @@
     },
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "C9-1",
             "layer": "F.Cu"
@@ -168,8 +163,7 @@
             "pin": "C8-1",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {
@@ -182,8 +176,7 @@
     },
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "L10-1",
             "layer": "F.Cu"
@@ -228,8 +221,7 @@
             "pin": "J8-1",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {

tests/single_layer/tht_3pin_xlr_to_tht_3pin_xlr/autoroute_all.cmd

@@ -2,8 +2,7 @@
   "done": [
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "J2-2",
             "layer": "F.Cu"
@@ -28,8 +27,7 @@
             "pin": "J1-1",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {

tests/single_layer/tht_diode_bridge_rectifier/autoroute_all.cmd

@@ -2,8 +2,7 @@
   "done": [
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "J2-2",
             "layer": "F.Cu"
@@ -48,8 +47,7 @@
             "pin": "J1-2",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {
@@ -62,8 +60,7 @@
     },
     {
       "Autoroute": [
-        {
+        [
-          "selectors": [
           {
             "pin": "D4-2",
             "layer": "F.Cu"
@@ -72,8 +69,7 @@
             "pin": "J2-2",
             "layer": "F.Cu"
           }
-          ]
+        ],
-        },
         {
           "presort_by_pairwise_detours": false,
           "router_options": {