berkus
/
miette
mirror of https://github.com/zkat/miette.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

perf(handlers): optimize string-buffer reallocations (#387) 

This improves `get_lines()` logic by using a string-buffer with a capacity hint.
That avoids growing the buffer from zero each time, saving a bunch of reallocations.
This commit is contained in:
Luca Bruno 2024-06-26 18:31:31 +02:00 committed by GitHub
parent e1026f75e0
commit b8dfcda4a8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/handlers/graphical.rs
View File

@ -1188,9 +1188,9 @@ impl GraphicalReportHandler {
let mut column = context_data.column();
let mut offset = context_data.span().offset();
let mut line_offset = offset;
let mut line_str = String::with_capacity(context.len());
let mut lines = Vec::with_capacity(1);
let mut iter = context.chars().peekable();
let mut line_str = String::new();
let mut lines = Vec::new();
while let Some(char) = iter.next() {
offset += char.len_utf8();
let mut at_end_of_file = false;

4
src/handlers/narratable.rs
View File

@ -295,9 +295,9 @@ impl NarratableReportHandler {
let mut column = context_data.column();
let mut offset = context_data.span().offset();
let mut line_offset = offset;
let mut line_str = String::with_capacity(context.len());
let mut lines = Vec::with_capacity(1);
let mut iter = context.chars().peekable();
let mut line_str = String::new();
let mut lines = Vec::new();
while let Some(char) = iter.next() {
offset += char.len_utf8();
let mut at_end_of_file = false;