From 82c1f1c07669fe8389a4b0beedc77aa7d4b287a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kat=20March=C3=A1n?= Date: Thu, 2 Jan 2025 16:33:50 -0800 Subject: [PATCH] fix(fallback): play around with fallback logic some more --- src/document.rs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/document.rs b/src/document.rs index ccf250f..03a2e78 100644 --- a/src/document.rs +++ b/src/document.rs @@ -354,12 +354,15 @@ impl KdlDocument { let v2_res = KdlDocument::parse_v2(s); if v2_res.is_err() { let v1_res = KdlDocument::parse_v2(s); - if v1_res.is_err() && detect_v2(s) { - v2_res - } else if detect_v1(s) { + if v1_res.is_ok() || detect_v1(s) { v1_res + } else if detect_v2(s) { + // v2, but with confidence + v2_res } else { - // This does matter, because detection short-circuits. + // TODO(@zkat): maybe we can add something to the error + // message to specify that it's "uncertain"? + // YOLO. v2_res } } else {