From 98cb1c0400b9acb769fccec4241629aab022abee Mon Sep 17 00:00:00 2001 From: nakst <> Date: Sat, 11 Sep 2021 19:02:30 +0100 Subject: [PATCH] cleanup --- desktop/api.s | 4 ++-- desktop/settings.cpp | 2 +- kernel/syscall.cpp | 1 - shared/heap.cpp | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/desktop/api.s b/desktop/api.s index 9095250..2d6bcf8 100644 --- a/desktop/api.s +++ b/desktop/api.s @@ -80,8 +80,8 @@ ProcessorCheckStackAlignment: jne $ ret -[global ProcessorRBPRead] -ProcessorRBPRead: +[global ProcessorGetRBP] +ProcessorGetRBP: mov rax,rbp ret diff --git a/desktop/settings.cpp b/desktop/settings.cpp index 3a89c1a..bc6ba9f 100644 --- a/desktop/settings.cpp +++ b/desktop/settings.cpp @@ -557,7 +557,7 @@ void SettingsPageDisplay(EsElement *element, SettingsPage *page) { } void SettingsPageTheme(EsElement *element, SettingsPage *page) { - // TODO. + // TODO Fonts, theme file, etc. EsElementSetHidden(((SettingsInstance *) element->instance)->undoButton, false); diff --git a/kernel/syscall.cpp b/kernel/syscall.cpp index d272224..485cc8c 100644 --- a/kernel/syscall.cpp +++ b/kernel/syscall.cpp @@ -303,7 +303,6 @@ SYSCALL_IMPLEMENT(ES_SYSCALL_PROCESS_CREATE) { // Start the process. if (error != ES_SUCCESS || !process->StartWithNode(executableObject)) { - // TODO Confirm that this frees the handle table. error = ES_ERROR_UNKNOWN; // TODO. CloseHandleToObject(process, KERNEL_OBJECT_PROCESS); } else { diff --git a/shared/heap.cpp b/shared/heap.cpp index f50d6ba..c2e21bc 100644 --- a/shared/heap.cpp +++ b/shared/heap.cpp @@ -45,7 +45,7 @@ static uintptr_t HeapCalculateIndex(uintptr_t size) { } #ifdef MEMORY_LEAK_DETECTOR -extern "C" uint64_t ProcessorRBPRead(); +extern "C" uint64_t ProcessorGetRBP(); struct MemoryLeakDetectorEntry { void *address; @@ -122,7 +122,7 @@ static void MemoryLeakDetectorAdd(EsHeap *heap, void *address, size_t bytes) { entry->bytes = bytes; entry->seenCount = 0; - uint64_t rbp = ProcessorRBPRead(); + uint64_t rbp = ProcessorGetRBP(); uintptr_t traceDepth = 0; while (rbp && traceDepth < sizeof(entry->stack) / sizeof(entry->stack[0])) {