cacache-rs

History

C J Silverio 6d84ff0aed fix(write): set tmpfile length in async writer (#35 ) Fixes: https://github.com/zkat/cacache-rs/issues/34 The async `poll_write()` implementation was creating a tempfile as a backing for its inner mmap, but it was failing to set the length on the file to match the incoming data. Compare with the sync implementation! This bug was exposed when the `memmap2` crate was swapped in for `memmap`. The older crate was likely more lax about this. Wrote a pair of new tests for `cacache::write_hash_sync` and `cacache::write_hash`. The async test fails without this change, as does any benchmarks run. Everything passes with it. BREAKING CHANGE: This commit also bumps the MSRV for cacache to 1.66.1.	2023-01-23 17:37:34 -08:00
..
ci.yml	fix(write): set tmpfile length in async writer (#35 )	2023-01-23 17:37:34 -08:00

fix(write): set tmpfile length in async writer (#35 )

Fixes: https://github.com/zkat/cacache-rs/issues/34

The async `poll_write()` implementation was creating a tempfile as
a backing for its inner mmap, but it was failing to set the length
on the file to match the incoming data. Compare with the sync
implementation!

This bug was exposed when the `memmap2` crate was swapped in
for `memmap`. The older crate was likely more lax about this.

Wrote a pair of new tests for `cacache::write_hash_sync` and
`cacache::write_hash`. The async test fails without this change, as
does any benchmarks run. Everything passes with it.

BREAKING CHANGE: This commit also bumps the MSRV for cacache to 1.66.1.

2023-01-23 17:37:34 -08:00

ci.yml

fix(write): set tmpfile length in async writer (#35 )

2023-01-23 17:37:34 -08:00