Fix CI with some linting

- Removed extraneous commented-out dep from testing.
- Updated Rust edition to 2021, as CI demanded.
- Ran `cargo clippy --fix` to remove all the new lints.

Cargo.toml

@@ -2,7 +2,7 @@
 name = "cacache"
 version = "10.0.2-alpha.0"
 authors = ["Kat Marchán <kzm@zkat.tech>"]
-edition = "2018"
+edition = "2021"
 description = "Content-addressable, key-value, high-performance, on-disk cache."
 license = "Apache-2.0"
 repository = "https://github.com/zkat/cacache-rs"

benches/benchmarks.rs

@@ -26,7 +26,7 @@ fn baseline_read_many_sync(c: &mut Criterion) {
         .collect();
     let data = b"hello world";
     for path in paths.iter() {
-        let mut fd = File::create(&path).unwrap();
+        let mut fd = File::create(path).unwrap();
         fd.write_all(data).unwrap();
         drop(fd);
     }
@@ -59,7 +59,7 @@ fn baseline_read_many_async(c: &mut Criterion) {
         .collect();
     let data = b"hello world";
     for path in paths.iter() {
-        let mut fd = File::create(&path).unwrap();
+        let mut fd = File::create(path).unwrap();
         fd.write_all(data).unwrap();
         drop(fd);
     }

src/content/read.rs

@@ -70,7 +70,7 @@ pub async fn open_async(cache: &Path, sri: Integrity) -> Result<AsyncReader> {
 
 pub fn read(cache: &Path, sri: &Integrity) -> Result<Vec<u8>> {
     let cpath = path::content_path(cache, sri);
-    let ret = fs::read(&cpath).to_internal()?;
+    let ret = fs::read(cpath).to_internal()?;
     sri.check(&ret)?;
     Ok(ret)
 }

src/content/write.rs

@@ -10,7 +10,6 @@ use async_std::task::{self, Context, JoinHandle, Poll};
 use futures::io::AsyncWrite;
 use futures::prelude::*;
 use memmap2::MmapMut;
-// use memmap::MmapMut;
 use ssri::{Algorithm, Integrity, IntegrityOpts};
 use tempfile::NamedTempFile;
 

src/get.rs

@@ -169,7 +169,7 @@ pub async fn read_hash<P>(cache: P, sri: &Integrity) -> Result<Vec<u8>>
 where
     P: AsRef<Path>,
 {
-    Ok(read::read_async(cache.as_ref(), sri).await?)
+    read::read_async(cache.as_ref(), sri).await
 }
 
 /// Copies cache data to a specified location. Returns the number of bytes
@@ -235,7 +235,7 @@ where
     P: AsRef<Path>,
     K: AsRef<str>,
 {
-    Ok(index::find_async(cache.as_ref(), key.as_ref()).await?)
+    index::find_async(cache.as_ref(), key.as_ref()).await
 }
 
 /// Returns true if the given hash exists in the cache.
@@ -584,9 +584,9 @@ mod tests {
         let tmp = tempfile::tempdir().unwrap();
         let dir = tmp.path();
         let dest = dir.join("data");
-        crate::write_sync(&dir, "my-key", b"hello world").unwrap();
+        crate::write_sync(dir, "my-key", b"hello world").unwrap();
 
-        crate::copy_sync(&dir, "my-key", &dest).unwrap();
+        crate::copy_sync(dir, "my-key", &dest).unwrap();
         let data = fs::read(&dest).unwrap();
         assert_eq!(data, b"hello world");
     }
@@ -596,9 +596,9 @@ mod tests {
         let tmp = tempfile::tempdir().unwrap();
         let dir = tmp.path();
         let dest = dir.join("data");
-        let sri = crate::write_sync(&dir, "my-key", b"hello world").unwrap();
+        let sri = crate::write_sync(dir, "my-key", b"hello world").unwrap();
 
-        crate::copy_hash_sync(&dir, &sri, &dest).unwrap();
+        crate::copy_hash_sync(dir, &sri, &dest).unwrap();
         let data = fs::read(&dest).unwrap();
         assert_eq!(data, b"hello world");
     }

src/index.rs

@@ -267,13 +267,13 @@ fn bucket_path(cache: &Path, key: &str) -> PathBuf {
 
 fn hash_key(key: &str) -> String {
     let mut hasher = Sha1::new();
-    hasher.update(&key);
+    hasher.update(key);
     hex::encode(hasher.finalize())
 }
 
 fn hash_entry(key: &str) -> String {
     let mut hasher = Sha256::new();
-    hasher.update(&key);
+    hasher.update(key);
     hex::encode(hasher.finalize())
 }
 

src/rm.rs

@@ -66,7 +66,7 @@ where
 /// }
 /// ```
 pub async fn remove_hash<P: AsRef<Path>>(cache: P, sri: &Integrity) -> Result<()> {
-    Ok(rm::rm_async(cache.as_ref(), sri).await?)
+    rm::rm_async(cache.as_ref(), sri).await
 }
 
 /// Removes entire contents of the cache, including temporary files, the entry