From 8e99d580b80d7e0970611f3dc05ad3e627a29e00 Mon Sep 17 00:00:00 2001 From: Victor Koenders Date: Sat, 25 Sep 2021 09:25:50 +0200 Subject: [PATCH] Removed `allow` attributes, fixed some warnings --- src/features/impl_std.rs | 8 +++----- src/varint/decode_signed.rs | 7 ------- src/varint/decode_unsigned.rs | 5 ----- tests/derive.rs | 1 + 4 files changed, 4 insertions(+), 17 deletions(-) diff --git a/src/features/impl_std.rs b/src/features/impl_std.rs index 22b0ac1..31d9758 100644 --- a/src/features/impl_std.rs +++ b/src/features/impl_std.rs @@ -4,14 +4,12 @@ use crate::{ error::DecodeError, }; -pub fn decode_from<'__de, D: Decodable, R: std::io::Read>( - src: &'__de mut R, -) -> Result { +pub fn decode_from(src: &mut R) -> Result { decode_from_with_config(src, config::Default) } -pub fn decode_from_with_config<'__de, D: Decodable, C: Config, R: std::io::Read>( - src: &'__de mut R, +pub fn decode_from_with_config( + src: &mut R, _config: C, ) -> Result { let mut decoder = Decoder::<_, C>::new(src, _config); diff --git a/src/varint/decode_signed.rs b/src/varint/decode_signed.rs index 1eae254..d762344 100644 --- a/src/varint/decode_signed.rs +++ b/src/varint/decode_signed.rs @@ -1,8 +1,5 @@ -#![allow(unused_variables)] - use crate::{config::Endian, de::read::Reader, error::DecodeError}; -#[allow(dead_code)] pub fn varint_decode_i16<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -22,7 +19,6 @@ pub fn varint_decode_i16<'a, R: Reader<'a>>( }) } -#[allow(dead_code)] pub fn varint_decode_i32<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -42,7 +38,6 @@ pub fn varint_decode_i32<'a, R: Reader<'a>>( }) } -#[allow(dead_code)] pub fn varint_decode_i64<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -62,7 +57,6 @@ pub fn varint_decode_i64<'a, R: Reader<'a>>( }) } -#[allow(dead_code)] pub fn varint_decode_i128<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -82,7 +76,6 @@ pub fn varint_decode_i128<'a, R: Reader<'a>>( }) } -#[allow(dead_code)] pub fn varint_decode_isize<'a, R: Reader<'a>>( read: &mut R, endian: Endian, diff --git a/src/varint/decode_unsigned.rs b/src/varint/decode_unsigned.rs index 24d60d6..53ac0e7 100644 --- a/src/varint/decode_unsigned.rs +++ b/src/varint/decode_unsigned.rs @@ -5,7 +5,6 @@ use crate::{ error::{DecodeError, IntegerType}, }; -#[allow(dead_code)] pub fn varint_decode_u16<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -37,7 +36,6 @@ pub fn varint_decode_u16<'a, R: Reader<'a>>( } } -#[allow(dead_code)] pub fn varint_decode_u32<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -73,7 +71,6 @@ pub fn varint_decode_u32<'a, R: Reader<'a>>( } } -#[allow(dead_code)] pub fn varint_decode_u64<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -113,7 +110,6 @@ pub fn varint_decode_u64<'a, R: Reader<'a>>( } } -#[allow(dead_code)] pub fn varint_decode_usize<'a, R: Reader<'a>>( read: &mut R, endian: Endian, @@ -153,7 +149,6 @@ pub fn varint_decode_usize<'a, R: Reader<'a>>( } } -#[allow(dead_code)] pub fn varint_decode_u128<'a, R: Reader<'a>>( read: &mut R, endian: Endian, diff --git a/tests/derive.rs b/tests/derive.rs index c32701b..b6aa2fe 100644 --- a/tests/derive.rs +++ b/tests/derive.rs @@ -53,6 +53,7 @@ fn test_encodable() { assert_eq!(&slice[..bytes_written], &[10, 10, 20]); } +#[cfg(feature = "std")] #[test] fn test_decodable() { let start = Test2 {