Go to file
asonix 4df9953c86
actix-http: h1: stop pipelining when not reading full requests (#3721)
* actix-http: h1: stop pipelining when not reading full requests

The existing pipelining behavior of the h1 dispatcher can cause client timeouts
if the entire request body isn't read. It puts the dispatcher into a state where
it refuses to read more (payload dropped) but there are still bytes in the buffer
from the request body.

This solution adds the SHUTDOWN flag in addition to the FINISHED flag
when completing a response when both the following are true:

1. There are no messages in `this.messages`
2. There is still a payload in `this.payload`

This combination implies two things. First, that we have not parsed a
pipelined request after the request we have just responded to. Second,
that the current request payload has not been fed an EOF. Because there
are no pipelined requests, we know that the current request payload
belongs to the request we have just responded to, and because the
request payload has not been fed an EOF, we know we never finished
reading it.

When this occurs, adding the SHUTDOWN flag to the dispatcher triggers a
`flush` and a `poll_shutdown` on the IO resource on the next poll.

* Remove printlns from dispatcher

* Add test that fails without changes & passes with changes

* Add changelog entry for h1 shutdown

---------

Co-authored-by: Rob Ede <robjtede@icloud.com>
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
2025-10-05 01:07:35 +00:00
.github build(deps): bump taiki-e/cache-cargo-install-action from 2.3.0 to 2.3.1 (#3782) 2025-09-29 01:26:26 +00:00
actix-files fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
actix-http actix-http: h1: stop pipelining when not reading full requests (#3721) 2025-10-05 01:07:35 +00:00
actix-http-test fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
actix-multipart fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
actix-multipart-derive fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
actix-router fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
actix-test fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
actix-web Add option to allow/disallow half closures in HTTP/1 (#3777) 2025-10-04 23:03:26 +00:00
actix-web-actors fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
actix-web-codegen fix: rename doc_auto_cfg feature (#3787) 2025-09-29 10:42:56 +00:00
awc fix(awc): close connections after GO_AWAY local or remote GO_AWAY errors (#3790) 2025-10-05 00:44:02 +00:00
docs/graphs bump actix-codec to 0.5 2022-02-15 20:49:10 +00:00
scripts chore: add multi-crate publish script 2025-08-26 09:25:22 +01:00
.clippy.toml chore(actix-http): prepare release 3.11.1 2025-08-26 07:28:27 +01:00
.codecov.yml chore: move codecov file 2023-08-03 06:28:45 +01:00
.cspell.yml refactor: init hickory DNS using OnceCell 2025-09-09 09:03:09 +01:00
.gitignore chore: check in lockfile 2025-03-21 05:51:45 +00:00
.prettierrc.yml format project 2024-01-10 04:00:20 +00:00
.rustfmt.toml apply standard formatting 2023-07-17 02:38:12 +01:00
.taplo.toml chore(actix-http): prepare release 3.11.0 2025-05-10 06:18:25 +01:00
CHANGES.md prepare releases: actix-http 3.0.0 and actix-web 4.0.0 (#2663) 2022-02-25 18:46:35 +00:00
CODE_OF_CONDUCT.md use dash hyphenation in markdown 2021-12-22 08:21:30 +00:00
Cargo.lock build(deps): bump tempfile from 3.22.0 to 3.23.0 (#3785) 2025-09-29 07:44:59 +00:00
Cargo.toml chore: narrow tokio dep to account for RUSTSEC-2025-0023 2025-05-10 06:09:51 +01:00
LICENSE-APACHE the big three point oh (#1668) 2020-09-11 13:50:10 +01:00
LICENSE-MIT update year in MIT license (#2143) 2021-04-09 01:28:35 +01:00
README.md move actix-web to own dir 2022-02-01 00:30:41 +00:00
justfile ci: pin time crate for msrv 2025-09-06 21:31:35 +01:00

README.md

Actix Web

Actix Web is a powerful, pragmatic, and extremely fast web framework for Rust

crates.io Documentation MSRV MIT or Apache 2.0 licensed Dependency Status
CI codecov downloads Chat on Discord

Features

  • Supports HTTP/1.x and HTTP/2
  • Streaming and pipelining
  • Powerful request routing with optional macros
  • Full Tokio compatibility
  • Keep-alive and slow requests handling
  • Client/server WebSockets support
  • Transparent content compression/decompression (br, gzip, deflate, zstd)
  • Multipart streams
  • Static assets
  • SSL support using OpenSSL or Rustls
  • Middlewares (Logger, Session, CORS, etc)
  • Integrates with the awc HTTP client
  • Runs on stable Rust 1.72+

Documentation

Example

Dependencies:

[dependencies]
actix-web = "4"

Code:

use actix_web::{get, web, App, HttpServer, Responder};

#[get("/hello/{name}")]
async fn greet(name: web::Path<String>) -> impl Responder {
    format!("Hello {name}!")
}

#[actix_web::main] // or #[tokio::main]
async fn main() -> std::io::Result<()> {
    HttpServer::new(|| {
        App::new().service(greet)
    })
    .bind(("127.0.0.1", 8080))?
    .run()
    .await
}

More Examples

You may consider checking out this directory for more examples.

Benchmarks

One of the fastest web frameworks available according to the TechEmpower Framework Benchmark.

License

This project is licensed under either of the following licenses, at your option:

Code of Conduct

Contribution to the actix/actix-web repo is organized under the terms of the Contributor Covenant. The Actix team promises to intervene to uphold that code of conduct.