mirror of https://github.com/fafhrd91/actix-web
4df9953c86
* actix-http: h1: stop pipelining when not reading full requests The existing pipelining behavior of the h1 dispatcher can cause client timeouts if the entire request body isn't read. It puts the dispatcher into a state where it refuses to read more (payload dropped) but there are still bytes in the buffer from the request body. This solution adds the SHUTDOWN flag in addition to the FINISHED flag when completing a response when both the following are true: 1. There are no messages in `this.messages` 2. There is still a payload in `this.payload` This combination implies two things. First, that we have not parsed a pipelined request after the request we have just responded to. Second, that the current request payload has not been fed an EOF. Because there are no pipelined requests, we know that the current request payload belongs to the request we have just responded to, and because the request payload has not been fed an EOF, we know we never finished reading it. When this occurs, adding the SHUTDOWN flag to the dispatcher triggers a `flush` and a `poll_shutdown` on the IO resource on the next poll. * Remove printlns from dispatcher * Add test that fails without changes & passes with changes * Add changelog entry for h1 shutdown --------- Co-authored-by: Rob Ede <robjtede@icloud.com> Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com> |
||
|---|---|---|
| .. | ||
| body | ||
| encoding | ||
| h1 | ||
| h2 | ||
| header | ||
| requests | ||
| responses | ||
| ws | ||
| builder.rs | ||
| config.rs | ||
| date.rs | ||
| error.rs | ||
| extensions.rs | ||
| helpers.rs | ||
| http_message.rs | ||
| keep_alive.rs | ||
| lib.rs | ||
| message.rs | ||
| notify_on_drop.rs | ||
| payload.rs | ||
| service.rs | ||
| test.rs | ||