berkus
/
actix-web
mirror of https://github.com/fafhrd91/actix-web
1
0
Fork 0
Code Issues Releases Wiki Activity

fix camel case test

This commit is contained in:
Rob Ede 2022-01-29 05:20:57 +00:00
parent 20ebd06e84
commit d1d7b8676d
No known key found for this signature in database
GPG Key ID: 97C636207D3EF933
3 changed files with 4 additions and 175 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
actix-http/src/responses/head.rs
View File

@ -240,8 +240,8 @@ mod tests {
let _ = stream let _ = stream
.write_all(b"GET /camel HTTP/1.1\r\nConnection: Close\r\n\r\n") .write_all(b"GET /camel HTTP/1.1\r\nConnection: Close\r\n\r\n")
.unwrap(); .unwrap();
let mut data = vec![0; 256]; let mut data = vec![];
let _ = stream.read(&mut data).unwrap(); let _ = stream.read_to_end(&mut data).unwrap();
assert_eq!(&data[..17], b"HTTP/1.1 200 OK\r\n"); assert_eq!(&data[..17], b"HTTP/1.1 200 OK\r\n");
assert!(memmem::find(&data, b"Foo-Bar").is_some()); assert!(memmem::find(&data, b"Foo-Bar").is_some());
assert!(memmem::find(&data, b"foo-bar").is_none()); assert!(memmem::find(&data, b"foo-bar").is_none());
@ -254,8 +254,8 @@ mod tests {
let _ = stream let _ = stream
.write_all(b"GET /lower HTTP/1.1\r\nConnection: Close\r\n\r\n") .write_all(b"GET /lower HTTP/1.1\r\nConnection: Close\r\n\r\n")
.unwrap(); .unwrap();
let mut data = vec![0; 256]; let mut data = vec![];
let _ = stream.read(&mut data).unwrap(); let _ = stream.read_to_end(&mut data).unwrap();
assert_eq!(&data[..17], b"HTTP/1.1 200 OK\r\n"); assert_eq!(&data[..17], b"HTTP/1.1 200 OK\r\n");
assert!(memmem::find(&data, b"Foo-Bar").is_none()); assert!(memmem::find(&data, b"Foo-Bar").is_none());
assert!(memmem::find(&data, b"foo-bar").is_some()); assert!(memmem::find(&data, b"foo-bar").is_some());

36
actix-http/tests/test_server.rs
View File

@ -196,42 +196,6 @@ async fn test_chunked_payload() {
srv.stop().await; srv.stop().await;
} }
#[actix_rt::test]
async fn slow_request_close() {
let mut srv = test_server(|| {
HttpService::build()
.client_timeout(200)
.keep_alive(2)
.finish(|_| ok::<_, Infallible>(Response::ok()))
.tcp()
})
.await;
let start = Instant::now();
let mut stream = net::TcpStream::connect(srv.addr()).unwrap();
let mut data = String::new();
let _ = stream.read_to_string(&mut data).unwrap();
assert!(
data.starts_with("HTTP/1.1 408 Request Timeout"),
"response was not 408: {}",
data
);
let diff = Instant::now().duration_since(start);
if diff < Duration::from_secs(1) {
// test success
} else if diff < Duration::from_secs(3) {
panic!("request seems to have wrongly timed-out according to keep-alive");
} else {
panic!("request took way too long to time out");
}
srv.stop().await;
}
#[actix_rt::test] #[actix_rt::test]
async fn slow_request_408() { async fn slow_request_408() {
let mut srv = test_server(|| { let mut srv = test_server(|| {

135
keep-alive-bug.txt
View File

@ -1,135 +0,0 @@
behavior
template
========================
client_timeout 0
keep_alive 2
unchanged
req 1
req 2
set started on first I/O poll
req 1
req 2
========================
======================================================
======================================================
========================
client_timeout 0
keep_alive 0
unchanged
req 1 OK
req 2 OK (~17s)
set started on first I/O poll
req 1 OK
req 2 OK (~17s)
========================
========================
client_timeout 2000
keep_alive 0
unchanged
req 1 OK
req 2 OK (~17s)
set started on first I/O poll
req 1 OK
req 2 OK (~17s)
========================
========================
client_timeout 2000
keep_alive 2
unchanged
req 1 OK
req 2 408 (~7s)
set started on first I/O poll
req 1 OK
req 2 conn reset (~7s)
attempt 1 (no good, 408 is broken)
req 1 OK
req 2 OK (~17s)
========================
========================
client_timeout 0
keep_alive 2
unchanged
req 1 OK
req 2 408 (~7s)
set started on first I/O poll
req 1 OK
req 2 conn reset (~7s)
attempt 1 (no good, 408 is broken)
req 1 OK
req 2 OK (~17s)
========================
========================
client_timeout 0
keep_alive Disabled
unchanged
req 1 OK
req 2 OK (~17s)
set started on first I/O poll
req 1 conn reset (instant)
req 2 -
========================
========================
client_timeout 2000
keep_alive Disabled
unchanged
req 1 OK
req 2 OK (~17s)
set started on first I/O poll
req 1 conn reset (instant)
req 2 -
========================
========================
client_timeout 0
keep_alive OS
unchanged
req 1 OK
req 2 OK (~17s)
set started on first I/O poll
req 1 OK
req 2 OK (~17s)
========================
========================
client_timeout 0
keep_alive 60
unchanged
req 1 OK
req 2 OK (~17s)
set started on first I/O poll
req 1 OK
req 2 OK (~17s)
========================