diff --git a/.github/workflows/upload-doc.yml b/.github/workflows/upload-doc.yml
index c080dd8c3..94a2ddfbe 100644
--- a/.github/workflows/upload-doc.yml
+++ b/.github/workflows/upload-doc.yml
@@ -1,14 +1,12 @@
-name: Upload documentation
+name: Upload Documentation
on:
push:
- branches:
- - master
+ branches: [master]
jobs:
build:
runs-on: ubuntu-latest
- if: github.repository == 'actix/actix-web'
steps:
- uses: actions/checkout@v2
@@ -20,14 +18,14 @@ jobs:
profile: minimal
override: true
- - name: check build
+ - name: Build Docs
uses: actions-rs/cargo@v1
with:
command: doc
args: --workspace --all-features --no-deps
- name: Tweak HTML
- run: echo "" > target/doc/index.html
+ run: echo '' > target/doc/index.html
- name: Deploy to GitHub Pages
uses: JamesIves/github-pages-deploy-action@3.7.1
diff --git a/Cargo.toml b/Cargo.toml
index 1a1b8645c..3795bc7d2 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -66,7 +66,7 @@ required-features = ["compress"]
[[test]]
name = "test_server"
-required-features = ["compress"]
+required-features = ["compress", "cookies"]
[[example]]
name = "on_connect"
@@ -84,7 +84,7 @@ actix-rt = "2"
actix-server = "2.0.0-beta.3"
actix-service = "2.0.0-beta.4"
actix-utils = "3.0.0-beta.2"
-actix-tls = { version = "3.0.0-beta.3", default-features = false, optional = true }
+actix-tls = { version = "3.0.0-beta.4", default-features = false, optional = true }
actix-web-codegen = "0.5.0-beta.1"
actix-http = "3.0.0-beta.3"
diff --git a/actix-http-test/Cargo.toml b/actix-http-test/Cargo.toml
index 8ec073661..c880cba78 100644
--- a/actix-http-test/Cargo.toml
+++ b/actix-http-test/Cargo.toml
@@ -31,7 +31,7 @@ openssl = ["tls-openssl", "awc/openssl"]
[dependencies]
actix-service = "2.0.0-beta.4"
actix-codec = "0.4.0-beta.1"
-actix-tls = "3.0.0-beta.3"
+actix-tls = "3.0.0-beta.4"
actix-utils = "3.0.0-beta.2"
actix-rt = "2"
actix-server = "2.0.0-beta.3"
diff --git a/actix-http/Cargo.toml b/actix-http/Cargo.toml
index 60af7af2a..14a9ff1e1 100644
--- a/actix-http/Cargo.toml
+++ b/actix-http/Cargo.toml
@@ -48,7 +48,7 @@ actix-service = "2.0.0-beta.4"
actix-codec = "0.4.0-beta.1"
actix-utils = "3.0.0-beta.2"
actix-rt = "2"
-actix-tls = "3.0.0-beta.2"
+actix-tls = "3.0.0-beta.4"
ahash = "0.7"
base64 = "0.13"
@@ -61,7 +61,7 @@ derive_more = "0.99.5"
encoding_rs = "0.8"
futures-core = { version = "0.3.7", default-features = false, features = ["alloc"] }
futures-util = { version = "0.3.7", default-features = false, features = ["alloc", "sink"] }
-h2 = "0.3.0"
+h2 = "=0.3.0"
http = "0.2.2"
httparse = "1.3"
itoa = "0.4"
@@ -90,7 +90,7 @@ trust-dns-resolver = { version = "0.20.0", optional = true }
[dev-dependencies]
actix-server = "2.0.0-beta.3"
actix-http-test = { version = "3.0.0-beta.2", features = ["openssl"] }
-actix-tls = { version = "3.0.0-beta.2", features = ["openssl"] }
+actix-tls = { version = "3.0.0-beta.4", features = ["openssl"] }
criterion = "0.3"
env_logger = "0.8"
rcgen = "0.8"
diff --git a/actix-http/src/h1/service.rs b/actix-http/src/h1/service.rs
index b79453ebd..51303886b 100644
--- a/actix-http/src/h1/service.rs
+++ b/actix-http/src/h1/service.rs
@@ -94,10 +94,10 @@ mod openssl {
use super::*;
use actix_service::ServiceFactoryExt;
- use actix_tls::accept::openssl::{Acceptor, SslAcceptor, SslError, SslStream};
+ use actix_tls::accept::openssl::{Acceptor, SslAcceptor, SslError, TlsStream};
use actix_tls::accept::TlsError;
- impl H1Service, S, B, X, U>
+ impl H1Service, S, B, X, U>
where
S: ServiceFactory,
S::Error: Into,
@@ -108,7 +108,7 @@ mod openssl {
X::Error: Into,
X::InitError: fmt::Debug,
U: ServiceFactory<
- (Request, Framed, Codec>),
+ (Request, Framed, Codec>),
Config = (),
Response = (),
>,
@@ -131,7 +131,7 @@ mod openssl {
.map_err(TlsError::Tls)
.map_init_err(|_| panic!()),
)
- .and_then(|io: SslStream| {
+ .and_then(|io: TlsStream| {
let peer_addr = io.get_ref().peer_addr().ok();
ready(Ok((io, peer_addr)))
})
diff --git a/actix-http/src/h2/service.rs b/actix-http/src/h2/service.rs
index e00c8d968..0984b3f23 100644
--- a/actix-http/src/h2/service.rs
+++ b/actix-http/src/h2/service.rs
@@ -93,12 +93,12 @@ where
#[cfg(feature = "openssl")]
mod openssl {
use actix_service::{fn_factory, fn_service, ServiceFactoryExt};
- use actix_tls::accept::openssl::{Acceptor, SslAcceptor, SslError, SslStream};
+ use actix_tls::accept::openssl::{Acceptor, SslAcceptor, SslError, TlsStream};
use actix_tls::accept::TlsError;
use super::*;
- impl H2Service, S, B>
+ impl H2Service, S, B>
where
S: ServiceFactory,
S::Error: Into + 'static,
@@ -123,7 +123,7 @@ mod openssl {
.map_init_err(|_| panic!()),
)
.and_then(fn_factory(|| {
- ok::<_, S::InitError>(fn_service(|io: SslStream| {
+ ok::<_, S::InitError>(fn_service(|io: TlsStream| {
let peer_addr = io.get_ref().peer_addr().ok();
ok((io, peer_addr))
}))
diff --git a/actix-http/src/service.rs b/actix-http/src/service.rs
index fee26dcc3..402affb7e 100644
--- a/actix-http/src/service.rs
+++ b/actix-http/src/service.rs
@@ -185,10 +185,10 @@ where
mod openssl {
use super::*;
use actix_service::ServiceFactoryExt;
- use actix_tls::accept::openssl::{Acceptor, SslAcceptor, SslError, SslStream};
+ use actix_tls::accept::openssl::{Acceptor, SslAcceptor, SslError, TlsStream};
use actix_tls::accept::TlsError;
- impl HttpService, S, B, X, U>
+ impl HttpService, S, B, X, U>
where
S: ServiceFactory,
S::Error: Into + 'static,
@@ -201,13 +201,13 @@ mod openssl {
X::InitError: fmt::Debug,
>::Future: 'static,
U: ServiceFactory<
- (Request, Framed, h1::Codec>),
+ (Request, Framed, h1::Codec>),
Config = (),
Response = (),
>,
U::Error: fmt::Display + Into,
U::InitError: fmt::Debug,
- , h1::Codec>)>>::Future: 'static,
+ , h1::Codec>)>>::Future: 'static,
{
/// Create openssl based service
pub fn openssl(
@@ -225,7 +225,7 @@ mod openssl {
.map_err(TlsError::Tls)
.map_init_err(|_| panic!()),
)
- .and_then(|io: SslStream| async {
+ .and_then(|io: TlsStream| async {
let proto = if let Some(protos) = io.ssl().selected_alpn_protocol() {
if protos.windows(2).any(|window| window == b"h2") {
Protocol::Http2
diff --git a/awc/Cargo.toml b/awc/Cargo.toml
index 9beecc6d4..45b355aba 100644
--- a/awc/Cargo.toml
+++ b/awc/Cargo.toml
@@ -76,7 +76,7 @@ actix-http = { version = "3.0.0-beta.3", features = ["openssl"] }
actix-http-test = { version = "3.0.0-beta.2", features = ["openssl"] }
actix-utils = "3.0.0-beta.1"
actix-server = "2.0.0-beta.3"
-actix-tls = { version = "3.0.0-beta.3", features = ["openssl", "rustls"] }
+actix-tls = { version = "3.0.0-beta.4", features = ["openssl", "rustls"] }
brotli2 = "0.3.2"
flate2 = "1.0.13"
diff --git a/src/route.rs b/src/route.rs
index b6b2482cd..c157025b8 100644
--- a/src/route.rs
+++ b/src/route.rs
@@ -1,13 +1,13 @@
#![allow(clippy::rc_buffer)] // inner value is mutated before being shared (`Rc::get_mut`)
-use std::future::Future;
-use std::pin::Pin;
-use std::rc::Rc;
-use std::task::{Context, Poll};
+use std::{future::Future, rc::Rc};
use actix_http::{http::Method, Error};
-use actix_service::{Service, ServiceFactory};
-use futures_util::future::{ready, FutureExt, LocalBoxFuture};
+use actix_service::{
+ boxed::{self, BoxService, BoxServiceFactory},
+ Service, ServiceFactory,
+};
+use futures_core::future::LocalBoxFuture;
use crate::extract::FromRequest;
use crate::guard::{self, Guard};
@@ -16,33 +16,12 @@ use crate::responder::Responder;
use crate::service::{ServiceRequest, ServiceResponse};
use crate::HttpResponse;
-type BoxedRouteService = Box<
- dyn Service<
- ServiceRequest,
- Response = ServiceResponse,
- Error = Error,
- Future = LocalBoxFuture<'static, Result>,
- >,
->;
-
-type BoxedRouteNewService = Box<
- dyn ServiceFactory<
- ServiceRequest,
- Config = (),
- Response = ServiceResponse,
- Error = Error,
- InitError = (),
- Service = BoxedRouteService,
- Future = LocalBoxFuture<'static, Result>,
- >,
->;
-
/// Resource route definition
///
/// Route uses builder-like pattern for configuration.
/// If handler is not explicitly set, default *404 Not Found* handler is used.
pub struct Route {
- service: BoxedRouteNewService,
+ service: BoxServiceFactory<(), ServiceRequest, ServiceResponse, Error, ()>,
guards: Rc>>,
}
@@ -51,9 +30,7 @@ impl Route {
#[allow(clippy::new_without_default)]
pub fn new() -> Route {
Route {
- service: Box::new(RouteNewService::new(HandlerService::new(|| {
- ready(HttpResponse::NotFound())
- }))),
+ service: boxed::factory(HandlerService::new(HttpResponse::NotFound)),
guards: Rc::new(Vec::new()),
}
}
@@ -64,44 +41,26 @@ impl Route {
}
impl ServiceFactory for Route {
- type Config = ();
type Response = ServiceResponse;
type Error = Error;
- type InitError = ();
+ type Config = ();
type Service = RouteService;
- type Future = CreateRouteService;
+ type InitError = ();
+ type Future = LocalBoxFuture<'static, Result>;
fn new_service(&self, _: ()) -> Self::Future {
- CreateRouteService {
- fut: self.service.new_service(()),
- guards: self.guards.clone(),
- }
- }
-}
+ let fut = self.service.new_service(());
+ let guards = self.guards.clone();
-pub struct CreateRouteService {
- fut: LocalBoxFuture<'static, Result>,
- guards: Rc>>,
-}
-
-impl Future for CreateRouteService {
- type Output = Result;
-
- fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll {
- let this = self.get_mut();
-
- match this.fut.as_mut().poll(cx)? {
- Poll::Ready(service) => Poll::Ready(Ok(RouteService {
- service,
- guards: this.guards.clone(),
- })),
- Poll::Pending => Poll::Pending,
- }
+ Box::pin(async move {
+ let service = fut.await?;
+ Ok(RouteService { service, guards })
+ })
}
}
pub struct RouteService {
- service: BoxedRouteService,
+ service: BoxService,
guards: Rc>>,
}
@@ -121,9 +80,7 @@ impl Service for RouteService {
type Error = Error;
type Future = LocalBoxFuture<'static, Result>;
- fn poll_ready(&self, cx: &mut Context<'_>) -> Poll> {
- self.service.poll_ready(cx)
- }
+ actix_service::forward_ready!(service);
fn call(&self, req: ServiceRequest) -> Self::Future {
self.service.call(req)
@@ -224,80 +181,11 @@ impl Route {
R: Future + 'static,
R::Output: Responder + 'static,
{
- self.service = Box::new(RouteNewService::new(HandlerService::new(handler)));
+ self.service = boxed::factory(HandlerService::new(handler));
self
}
}
-struct RouteNewService
-where
- T: ServiceFactory,
-{
- service: T,
-}
-
-impl RouteNewService
-where
- T: ServiceFactory,
- T::Future: 'static,
- T::Service: 'static,
- >::Future: 'static,
-{
- pub fn new(service: T) -> Self {
- RouteNewService { service }
- }
-}
-
-impl ServiceFactory for RouteNewService
-where
- T: ServiceFactory,
- T::Future: 'static,
- T::Service: 'static,
- >::Future: 'static,
-{
- type Response = ServiceResponse;
- type Error = Error;
- type Config = ();
- type Service = BoxedRouteService;
- type InitError = ();
- type Future = LocalBoxFuture<'static, Result>;
-
- fn new_service(&self, _: ()) -> Self::Future {
- self.service
- .new_service(())
- .map(|result| match result {
- Ok(service) => {
- let service = Box::new(RouteServiceWrapper { service }) as _;
- Ok(service)
- }
- Err(_) => Err(()),
- })
- .boxed_local()
- }
-}
-
-struct RouteServiceWrapper> {
- service: T,
-}
-
-impl Service for RouteServiceWrapper
-where
- T::Future: 'static,
- T: Service,
-{
- type Response = ServiceResponse;
- type Error = Error;
- type Future = LocalBoxFuture<'static, Result>;
-
- fn poll_ready(&self, cx: &mut Context<'_>) -> Poll> {
- self.service.poll_ready(cx)
- }
-
- fn call(&self, req: ServiceRequest) -> Self::Future {
- Box::pin(self.service.call(req))
- }
-}
-
#[cfg(test)]
mod tests {
use std::time::Duration;
diff --git a/tests/test_server.rs b/tests/test_server.rs
index 2466730f9..b35af657d 100644
--- a/tests/test_server.rs
+++ b/tests/test_server.rs
@@ -21,6 +21,7 @@ use flate2::{
Compression,
};
use futures_util::ready;
+#[cfg(feature = "openssl")]
use openssl::{
pkey::PKey,
ssl::{SslAcceptor, SslMethod},
@@ -54,6 +55,7 @@ const STR: &str = "Hello World Hello World Hello World Hello World Hello World \
Hello World Hello World Hello World Hello World Hello World \
Hello World Hello World Hello World Hello World Hello World";
+#[cfg(feature = "openssl")]
fn openssl_config() -> SslAcceptor {
let cert = rcgen::generate_simple_self_signed(vec!["localhost".to_owned()]).unwrap();
let cert_file = cert.serialize_pem().unwrap();
@@ -786,11 +788,6 @@ mod plus_rustls {
#[actix_rt::test]
async fn test_reading_deflate_encoding_large_random_rustls() {
- use rustls::internal::pemfile::{certs, pkcs8_private_keys};
- use rustls::{NoClientAuth, ServerConfig};
- use std::fs::File;
- use std::io::BufReader;
-
let data = rand::thread_rng()
.sample_iter(&Alphanumeric)
.take(160_000)