From 838f7bdd7f6b4d1eda31ebc32fbba6dcd020a94e Mon Sep 17 00:00:00 2001 From: Rob Ede Date: Sun, 26 Feb 2023 03:57:15 +0000 Subject: [PATCH] document new method --- actix-test/CHANGES.md | 2 +- actix-test/src/lib.rs | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/actix-test/CHANGES.md b/actix-test/CHANGES.md index ba8bc8a9a..5dec9cf1f 100644 --- a/actix-test/CHANGES.md +++ b/actix-test/CHANGES.md @@ -2,8 +2,8 @@ ## Unreleased - 2022-xx-xx +- Add `TestServerConfig::port()` setter method. - Minimum supported Rust version (MSRV) is now 1.59 due to transitive `time` dependency. -- Ability to set port number in TestServerConfig ## 0.1.0 - 2022-07-24 diff --git a/actix-test/src/lib.rs b/actix-test/src/lib.rs index 031bebc7e..18453b599 100644 --- a/actix-test/src/lib.rs +++ b/actix-test/src/lib.rs @@ -145,11 +145,10 @@ where // run server in separate orphaned thread thread::spawn(move || { rt::System::new().block_on(async move { - let srv_cfg = cfg.clone(); - let port = srv_cfg.port; - let tcp = net::TcpListener::bind(format!("127.0.0.1:{port}")).unwrap(); + let tcp = net::TcpListener::bind(("127.0.0.1", cfg.port)).unwrap(); let local_addr = tcp.local_addr().unwrap(); let factory = factory.clone(); + let srv_cfg = cfg.clone(); let timeout = cfg.client_request_timeout; let builder = Server::build().workers(1).disable_signals().system_exit(); @@ -443,8 +442,11 @@ impl TestServerConfig { self } - pub fn port(mut self, _port: u16) -> Self { - self.port = _port; + /// Sets test server port. + /// + /// By default, a random free port is determined by the OS. + pub fn port(mut self, port: u16) -> Self { + self.port = port; self } }