From 5eb4ee27e88382179822d78057b567b228ff864b Mon Sep 17 00:00:00 2001 From: winkidney Date: Tue, 1 Jan 2019 00:49:41 -0800 Subject: [PATCH] Refactor: Use mut-ref to insert instead move of cookies value --- src/test.rs | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/test.rs b/src/test.rs index ee9ef8a7a..7f5762258 100644 --- a/src/test.rs +++ b/src/test.rs @@ -550,21 +550,19 @@ impl TestRequest { /// set cookie of this request pub fn cookie(mut self, cookie: Cookie<'static>) -> Self { let mut should_insert = true; - let mut cookies = match self.cookies { + match &mut self.cookies { Some(old_cookies) => { - for old_cookie in &old_cookies { + for old_cookie in old_cookies.iter() { if old_cookie == &cookie { should_insert = false }; - } - old_cookies + }; + if should_insert { + old_cookies.push(cookie); + }; } - None => { Vec::::new() } + None => {} }; - if should_insert { - cookies.push(cookie) - }; - self.cookies = Some(cookies); self }