berkus
/
actix-web
mirror of https://github.com/fafhrd91/actix-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Always append a colon after username in basic auth

This commit is contained in:
Alec Moskvin 2019-06-28 22:34:07 -04:00
parent 12b5174850
commit 4befd51c13
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
awc/src/builder.rs
View File

@ -115,7 +115,7 @@ impl ClientBuilder {
{ {
let auth = match password { let auth = match password {
Some(password) => format!("{}:{}", username, password), Some(password) => format!("{}:{}", username, password),
None => format!("{}", username), None => format!("{}:", username),
}; };
self.header( self.header(
header::AUTHORIZATION, header::AUTHORIZATION,
@ -164,7 +164,7 @@ mod tests {
.unwrap() .unwrap()
.to_str() .to_str()
.unwrap(), .unwrap(),
"Basic dXNlcm5hbWU=" "Basic dXNlcm5hbWU6"
); );
} }

4
awc/src/request.rs
View File

@ -280,7 +280,7 @@ impl ClientRequest {
{ {
let auth = match password { let auth = match password {
Some(password) => format!("{}:{}", username, password), Some(password) => format!("{}:{}", username, password),
None => format!("{}", username), None => format!("{}:", username),
}; };
self.header( self.header(
header::AUTHORIZATION, header::AUTHORIZATION,
@ -664,7 +664,7 @@ mod tests {
.unwrap() .unwrap()
.to_str() .to_str()
.unwrap(), .unwrap(),
"Basic dXNlcm5hbWU=" "Basic dXNlcm5hbWU6"
); );
} }

4
awc/src/ws.rs
View File

@ -195,7 +195,7 @@ impl WebsocketsRequest {
{ {
let auth = match password { let auth = match password {
Some(password) => format!("{}:{}", username, password), Some(password) => format!("{}:{}", username, password),
None => format!("{}", username), None => format!("{}:", username),
}; };
self.header(AUTHORIZATION, format!("Basic {}", base64::encode(&auth))) self.header(AUTHORIZATION, format!("Basic {}", base64::encode(&auth)))
} }
@ -443,7 +443,7 @@ mod tests {
.unwrap() .unwrap()
.to_str() .to_str()
.unwrap(), .unwrap(),
"Basic dXNlcm5hbWU=" "Basic dXNlcm5hbWU6"
); );
} }