From 0cd921b75856a181d247635c0567133ceb48432f Mon Sep 17 00:00:00 2001
From: Rob Ede <robjtede@icloud.com>
Date: Sun, 21 Nov 2021 20:59:57 +0000
Subject: [PATCH] set up CI manually for io-uring testing

---
 .cargo/config.toml         | 22 ++++++++---------
 .github/workflows/ci.yml   | 50 +++++++++++++++++++++++---------------
 src/middleware/compress.rs |  3 ++-
 3 files changed, 42 insertions(+), 33 deletions(-)

diff --git a/.cargo/config.toml b/.cargo/config.toml
index 47aeeb125..606c30de7 100644
--- a/.cargo/config.toml
+++ b/.cargo/config.toml
@@ -1,14 +1,12 @@
 [alias]
-chk = "check --workspace --all-features --tests --examples --bins"
-lint = "clippy --workspace --all-features --tests --examples --bins"
-ci-min = "hack check --workspace --no-default-features"
-ci-min-test = "hack check --workspace --no-default-features --tests --examples"
-ci-default = "check --workspace --bins --tests --examples"
-ci-full = "check --workspace --all-features --bins --tests --examples"
-ci-test = "test --workspace --all-features --lib --tests --no-fail-fast -- --nocapture"
-ci-doctest = "test --workspace --all-features --doc --no-fail-fast -- --nocapture"
+lint = "clippy --workspace --tests --examples --bins -- -Dclippy::todo"
+lint-all = "clippy --workspace --all-features --tests --examples --bins -- -Dclippy::todo"
 
-ci-feature-powerset-check-no-tls="hack --workspace --feature-powerset --skip=__compress,rustls,openssl,io-uring check"
-ci-feature-powerset-check-rustls="hack --workspace --feature-powerset --features=rustls --skip=__compress,openssl,io-uring check"
-ci-feature-powerset-check-openssl="hack --workspace --feature-powerset --features=openssl --skip=__compress,rustls,io-uring check"
-ci-feature-powerset-check-all="hack --workspace --feature-powerset --skip=__compress,io-uring check"
+# lib checking
+ci-check-min = "hack --workspace check --no-default-features"
+ci-check-default = "hack --workspace check"
+ci-check-all-feature-powerset="hack --workspace --feature-powerset --skip=__compress,io-uring check"
+ci-check-all-feature-powerset-linux="hack --workspace --feature-powerset --skip=__compress check"
+
+# testing
+ci-doctest = "test --workspace --all-features --doc --no-fail-fast -- --nocapture"
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8f586d8d8..9d521a8af 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -62,26 +62,33 @@ jobs:
 
       - name: check minimal
         uses: actions-rs/cargo@v1
-        with: { command: ci-min }
-
-      - name: check minimal + tests
-        uses: actions-rs/cargo@v1
-        with: { command: ci-min-test }
+        with: { command: ci-check-min }
 
       - name: check default
         uses: actions-rs/cargo@v1
-        with: { command: ci-default }
-      
-      - name: check full
-        uses: actions-rs/cargo@v1
-        with: { command: ci-full }
+        with: { command: ci-check-default }
 
       - name: tests
         uses: actions-rs/cargo@v1
         timeout-minutes: 60
-        with:
-          command: ci-test
-          args: --skip=test_reading_deflate_encoding_large_random_rustls
+        run: |
+          cargo test -p=actix-router --all-features
+          cargo test -p=actix-http --all-features
+          cargo test -p=actix-web --features=rustls,openssl --skip=test_reading_deflate_encoding_large_random_rustls
+          cargo test -p=actix-web-codegen --all-features
+          cargo test -p=awc --all-features
+          cargo test -p=actix-http-test --all-features
+          cargo test -p=actix-test --all-features
+          cargo test -p=actix-files
+          cargo test -p=actix-multipart --all-features
+          cargo test -p=actix-web-actors --all-features
+
+      - name: tests (io-uring)
+        if: matrix.target.os == 'ubuntu-latest'
+        uses: actions-rs/cargo@v1
+        timeout-minutes: 60
+        run: |
+          cargo test -p=actix-files --all-features
 
       - name: Clear the cargo caches
         run: |
@@ -114,9 +121,12 @@ jobs:
           args: cargo-hack
 
       - name: check feature combinations
-        # if: github.ref == 'refs/heads/master'
         uses: actions-rs/cargo@v1
-        with: { command: ci-feature-powerset-check-all }
+        with: { command: ci-check-all-feature-powerset }
+      
+      - name: check feature combinations
+        uses: actions-rs/cargo@v1
+        with: { command: ci-check-all-feature-powerset-linux }
 
   coverage:
     name: coverage
@@ -166,11 +176,11 @@ jobs:
       - name: Cache Dependencies
         uses: Swatinem/rust-cache@v1.3.0
 
-      - name: Install cargo-hack
-        uses: actions-rs/cargo@v1
-        with:
-          command: install
-          args: cargo-hack
+      # - name: Install cargo-hack
+      #   uses: actions-rs/cargo@v1
+      #   with:
+      #     command: install
+      #     args: cargo-hack
 
       - name: doc tests
         uses: actions-rs/cargo@v1
diff --git a/src/middleware/compress.rs b/src/middleware/compress.rs
index 3e85cb846..d8878a82a 100644
--- a/src/middleware/compress.rs
+++ b/src/middleware/compress.rs
@@ -82,7 +82,8 @@ pub struct CompressMiddleware<S> {
 }
 
 static SUPPORTED_ALGORITHM_NAMES: Lazy<String> = Lazy::new(|| {
-    let mut encoding = vec![];
+    #[allow(unused_mut)] // only unused when no compress features enabled
+    let mut encoding: Vec<&str> = vec![];
 
     #[cfg(feature = "compress-brotli")]
     {