berkus
/
actix-net
mirror of https://github.com/fafhrd91/actix-net
1
0
Fork 0
Code Issues Releases Wiki Activity

do not support external use

This commit is contained in:
Yuki Okushi 2026-05-07 19:49:07 +09:00
parent 063deead6b
commit d26ccb6c0b
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
actix-codec/src/lines.rs
View File

@ -16,18 +16,11 @@ use super::{Decoder, Encoder};
/// [`LinesCodec::new_with_max_length`]. Without a length limit, the internal read buffer can grow /// [`LinesCodec::new_with_max_length`]. Without a length limit, the internal read buffer can grow
/// without bound if a peer sends an unbounded amount of data without a `\n`, potentially leading /// without bound if a peer sends an unbounded amount of data without a `\n`, potentially leading
/// to memory exhaustion (DoS). /// to memory exhaustion (DoS).
///
/// # Direct `Decoder` Use
///
/// `LinesCodec` caches the index after the last byte it searched when [`Decoder::decode`] returns
/// `Ok(None)`. Callers that invoke `decode` directly must pass the same [`BytesMut`] with newly
/// read bytes appended. If the buffer is replaced or bytes before the cached offset are changed,
/// create a new `LinesCodec` before decoding the replacement buffer.
#[derive(Debug, Copy, Clone)] #[derive(Debug, Copy, Clone)]
#[non_exhaustive] #[non_exhaustive]
pub struct LinesCodec { pub struct LinesCodec {
max_length: usize, max_length: usize,
// Next byte index to examine for `\n` after a previous incomplete decode. // Next byte index to examine for `\n` after an incomplete decode.
next_index: usize, next_index: usize,
} }
@ -91,11 +84,13 @@ impl Decoder for LinesCodec {
return Ok(None); return Ok(None);
} }
let start = self.next_index.min(src.len()); // Framed reads append to the same buffer after incomplete decodes. We do not currently
debug_assert!( // expect callers to replace it, but fall back to a fresh scan if they do.
memchr(b'\n', &src[..start]).is_none(), let start = if self.next_index < src.len() {
"LinesCodec buffer changed before cached search offset" self.next_index
); } else {
0
};
let len = match memchr(b'\n', &src[start..]) { let len = match memchr(b'\n', &src[start..]) {
Some(n) => start + n, Some(n) => start + n,