standardize logs

This commit is contained in:
Rob Ede 2022-07-22 20:51:11 +01:00
parent dc21ad7e07
commit bcd65857df
No known key found for this signature in database
GPG Key ID: 97C636207D3EF933
9 changed files with 20 additions and 19 deletions

View File

@ -74,7 +74,7 @@ async fn run() -> io::Result<()> {
// close connection after file has been copied to TCP stream // close connection after file has been copied to TCP stream
Ok(()) Ok(())
}) })
.map_err(|err| tracing::error!("service Error: {:?}", err)) .map_err(|err| tracing::error!("service error: {:?}", err))
})? })?
.workers(2) .workers(2)
.run() .run()

View File

@ -64,7 +64,7 @@ async fn run() -> io::Result<()> {
// stream error; bail from loop with error // stream error; bail from loop with error
Err(err) => { Err(err) => {
tracing::error!("stream Error: {:?}", err); tracing::error!("stream error: {:?}", err);
return Err(()); return Err(());
} }
} }
@ -74,7 +74,7 @@ async fn run() -> io::Result<()> {
Ok((buf.freeze(), size)) Ok((buf.freeze(), size))
} }
}) })
.map_err(|err| tracing::error!("service Error: {:?}", err)) .map_err(|err| tracing::error!("service error: {:?}", err))
.and_then(move |(_, size)| { .and_then(move |(_, size)| {
let num = num2.load(Ordering::SeqCst); let num = num2.load(Ordering::SeqCst);
tracing::info!("[{}] total bytes read: {}", num, size); tracing::info!("[{}] total bytes read: {}", num, size);

View File

@ -193,9 +193,9 @@ impl ServerInner {
let is_tokio = tokio::runtime::Handle::try_current().is_ok(); let is_tokio = tokio::runtime::Handle::try_current().is_ok();
match (is_actix, is_tokio) { match (is_actix, is_tokio) {
(true, _) => info!("actix runtime found; starting in actix runtime"), (true, _) => info!("Actix runtime found; starting in Actix runtime"),
(_, true) => info!("tokio runtime found; starting in existing tokio runtime"), (_, true) => info!("Tokio runtime found; starting in existing Tokio runtime"),
(_, false) => panic!("actix or tokio runtime not found; halting"), (_, false) => panic!("Actix or Tokio runtime not found; halting"),
} }
for (_, name, lst) in &builder.sockets { for (_, name, lst) in &builder.sockets {

View File

@ -78,7 +78,7 @@ where
Ok(()) Ok(())
} }
Err(err) => { Err(err) => {
error!("can not convert to an async tcp stream: {}", err); error!("can not convert to an async TCP stream: {}", err);
Err(()) Err(())
} }
}) })

View File

@ -186,9 +186,9 @@ fn test_start() {
#[actix_rt::test] #[actix_rt::test]
async fn test_max_concurrent_connections() { async fn test_max_concurrent_connections() {
// Note: // Note:
// A tcp listener would accept connects based on it's backlog setting. // A TCP listener would accept connects based on it's backlog setting.
// //
// The limit test on the other hand is only for concurrent tcp stream limiting a work // The limit test on the other hand is only for concurrent TCP stream limiting a work
// thread accept. // thread accept.
use tokio::io::AsyncWriteExt; use tokio::io::AsyncWriteExt;

View File

@ -74,16 +74,16 @@ where
let connector = self.connector.clone(); let connector = self.connector.clone();
Box::pin(async move { Box::pin(async move {
trace!("SSL handshake start for: {:?}", stream.hostname()); trace!("TLS handshake start for: {:?}", stream.hostname());
connector connector
.connect(stream.hostname(), io) .connect(stream.hostname(), io)
.await .await
.map(|res| { .map(|res| {
trace!("SSL handshake success: {:?}", stream.hostname()); trace!("TLS handshake success: {:?}", stream.hostname());
stream.replace_io(res).1 stream.replace_io(res).1
}) })
.map_err(|e| { .map_err(|e| {
trace!("SSL handshake error: {:?}", e); trace!("TLS handshake error: {:?}", e);
io::Error::new(io::ErrorKind::Other, format!("{}", e)) io::Error::new(io::ErrorKind::Other, format!("{}", e))
}) })
}) })

View File

@ -97,7 +97,8 @@ where
actix_service::always_ready!(); actix_service::always_ready!();
fn call(&self, stream: Connection<R, IO>) -> Self::Future { fn call(&self, stream: Connection<R, IO>) -> Self::Future {
trace!("SSL handshake start for: {:?}", stream.hostname()); trace!("TLS handshake start for: {:?}", stream.hostname());
let (io, stream) = stream.replace_io(()); let (io, stream) = stream.replace_io(());
let host = stream.hostname(); let host = stream.hostname();
@ -137,11 +138,11 @@ where
match ready!(Pin::new(this.io.as_mut().unwrap()).poll_connect(cx)) { match ready!(Pin::new(this.io.as_mut().unwrap()).poll_connect(cx)) {
Ok(_) => { Ok(_) => {
let stream = this.stream.take().unwrap(); let stream = this.stream.take().unwrap();
trace!("SSL handshake success: {:?}", stream.hostname()); trace!("TLS handshake success: {:?}", stream.hostname());
Poll::Ready(Ok(stream.replace_io(this.io.take().unwrap()).1)) Poll::Ready(Ok(stream.replace_io(this.io.take().unwrap()).1))
} }
Err(err) => { Err(err) => {
trace!("SSL handshake error: {:?}", err); trace!("TLS handshake error: {:?}", err);
Poll::Ready(Err(io::Error::new( Poll::Ready(Err(io::Error::new(
io::ErrorKind::Other, io::ErrorKind::Other,
format!("{}", err), format!("{}", err),

View File

@ -101,7 +101,7 @@ where
actix_service::always_ready!(); actix_service::always_ready!();
fn call(&self, connection: Connection<R, IO>) -> Self::Future { fn call(&self, connection: Connection<R, IO>) -> Self::Future {
trace!("SSL handshake start for: {:?}", connection.hostname()); trace!("TLS handshake start for: {:?}", connection.hostname());
let (stream, connection) = connection.replace_io(()); let (stream, connection) = connection.replace_io(());
match ServerName::try_from(connection.hostname()) { match ServerName::try_from(connection.hostname()) {
@ -140,7 +140,7 @@ where
Self::Future { connect, connection } => { Self::Future { connect, connection } => {
let stream = ready!(Pin::new(connect).poll(cx))?; let stream = ready!(Pin::new(connect).poll(cx))?;
let connection = connection.take().unwrap(); let connection = connection.take().unwrap();
trace!("SSL handshake success: {:?}", connection.hostname()); trace!("TLS handshake success: {:?}", connection.hostname());
Poll::Ready(Ok(connection.replace_io(stream).1)) Poll::Ready(Ok(connection.replace_io(stream).1))
} }
} }

View File

@ -114,8 +114,8 @@ impl<R: Host> TcpConnectorFut<R> {
stream: ReusableBoxFuture::new(connect(addr, local_addr)), stream: ReusableBoxFuture::new(connect(addr, local_addr)),
}, },
// when resolver returns multiple socket addr for request they would be popped from // When resolver returns multiple socket addr for request they would be popped from
// front end of queue and returns with the first successful tcp connection. // front end of queue and returns with the first successful TCP connection.
ConnectAddrs::Multi(mut addrs) => { ConnectAddrs::Multi(mut addrs) => {
let addr = addrs.pop_front().unwrap(); let addr = addrs.pop_front().unwrap();