Reduce log level to debug for many messages

These messages provide very little benefit when not debugging.
This commit is contained in:
Thomas de Zeeuw 2021-10-15 14:14:21 +02:00
parent 00775884f8
commit b6b28b05cc
4 changed files with 15 additions and 11 deletions

View File

@ -2,6 +2,10 @@
## Unreleased - 2021-xx-xx ## Unreleased - 2021-xx-xx
* Reduce the log noise. [#394]
[#394]: https://github.com/actix/actix-net/pull/394
## 2.0.0-beta.6 - 2021-10-11 ## 2.0.0-beta.6 - 2021-10-11
* Add experimental (semver-exempt) `io-uring` feature for enabling async file I/O on linux. [#374] * Add experimental (semver-exempt) `io-uring` feature for enabling async file I/O on linux. [#374]

View File

@ -5,7 +5,7 @@ use actix_rt::{
time::{sleep, Instant}, time::{sleep, Instant},
System, System,
}; };
use log::{error, info}; use log::{debug, error};
use mio::{Interest, Poll, Token as MioToken}; use mio::{Interest, Poll, Token as MioToken};
use crate::server::Server; use crate::server::Server;
@ -234,7 +234,7 @@ impl Accept {
WAKER_TOKEN => { WAKER_TOKEN => {
let exit = self.handle_waker(sockets); let exit = self.handle_waker(sockets);
if exit { if exit {
info!("Accept is stopped."); debug!("Accept is stopped.");
return; return;
} }
} }
@ -370,14 +370,14 @@ impl Accept {
fn register_logged(&self, info: &mut ServerSocketInfo) { fn register_logged(&self, info: &mut ServerSocketInfo) {
match self.register(info) { match self.register(info) {
Ok(_) => info!("Resume accepting connections on {}", info.lst.local_addr()), Ok(_) => debug!("Resume accepting connections on {}", info.lst.local_addr()),
Err(e) => error!("Can not register server socket {}", e), Err(e) => error!("Can not register server socket {}", e),
} }
} }
fn deregister_logged(&self, info: &mut ServerSocketInfo) { fn deregister_logged(&self, info: &mut ServerSocketInfo) {
match self.poll.registry().deregister(&mut info.lst) { match self.poll.registry().deregister(&mut info.lst) {
Ok(_) => info!("Paused accepting connections on {}", info.lst.local_addr()), Ok(_) => debug!("Paused accepting connections on {}", info.lst.local_addr()),
Err(e) => { Err(e) => {
error!("Can not deregister server socket {}", e) error!("Can not deregister server socket {}", e)
} }

View File

@ -7,7 +7,7 @@ use std::{
}; };
use actix_rt::{self as rt, net::TcpStream, time::sleep, System}; use actix_rt::{self as rt, net::TcpStream, time::sleep, System};
use log::{error, info}; use log::{debug, error, info};
use tokio::sync::{ use tokio::sync::{
mpsc::{unbounded_channel, UnboundedReceiver}, mpsc::{unbounded_channel, UnboundedReceiver},
oneshot, oneshot,
@ -250,7 +250,7 @@ impl ServerBuilder {
if self.sockets.is_empty() { if self.sockets.is_empty() {
panic!("Server should have at least one bound socket"); panic!("Server should have at least one bound socket");
} else { } else {
info!("Starting {} workers", self.threads); debug!("Starting {} workers", self.threads);
// start workers // start workers
let handles = (0..self.threads) let handles = (0..self.threads)
@ -265,7 +265,7 @@ impl ServerBuilder {
// start accept thread // start accept thread
for sock in &self.sockets { for sock in &self.sockets {
info!("Starting \"{}\" service on {}", sock.1, sock.2); debug!("Starting \"{}\" service on {}", sock.1, sock.2);
} }
self.accept.start( self.accept.start(
mem::take(&mut self.sockets) mem::take(&mut self.sockets)

View File

@ -17,7 +17,7 @@ use actix_rt::{
Arbiter, Arbiter,
}; };
use futures_core::{future::LocalBoxFuture, ready}; use futures_core::{future::LocalBoxFuture, ready};
use log::{error, info, trace}; use log::{debug, error, trace};
use tokio::sync::{ use tokio::sync::{
mpsc::{unbounded_channel, UnboundedReceiver, UnboundedSender}, mpsc::{unbounded_channel, UnboundedReceiver, UnboundedSender},
oneshot, oneshot,
@ -465,11 +465,11 @@ impl Future for ServerWorker {
{ {
let num = this.counter.total(); let num = this.counter.total();
if num == 0 { if num == 0 {
info!("Shutting down worker, 0 connections"); debug!("Shutting down worker, 0 connections");
let _ = tx.send(true); let _ = tx.send(true);
return Poll::Ready(()); return Poll::Ready(());
} else if graceful { } else if graceful {
info!("Graceful worker shutdown, {} connections", num); debug!("Graceful worker shutdown, {} connections", num);
this.shutdown(false); this.shutdown(false);
this.state = WorkerState::Shutdown(Shutdown { this.state = WorkerState::Shutdown(Shutdown {
@ -478,7 +478,7 @@ impl Future for ServerWorker {
tx, tx,
}); });
} else { } else {
info!("Force shutdown worker, {} connections", num); debug!("Force shutdown worker, {} connections", num);
this.shutdown(true); this.shutdown(true);
let _ = tx.send(false); let _ = tx.send(false);