berkus
/
actix-net
mirror of https://github.com/fafhrd91/actix-net
1
0
Fork 0
Code Issues Releases Wiki Activity

perf(bytestring): micro-improve performance against ASCII conv

This commit is contained in:
Yuki Okushi 2026-04-27 06:16:03 +09:00
parent 347704329b
commit 44124dafe5
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
bytestring/CHANGES.md
View File

@ -4,6 +4,7 @@
- Minimum supported Rust version (MSRV) is now 1.88. - Minimum supported Rust version (MSRV) is now 1.88.
- Improve `From<ByteString> for String` performance. - Improve `From<ByteString> for String` performance.
- Improve ASCII `TryFrom` conversions performance.
## 1.5.0 ## 1.5.0

29
bytestring/src/lib.rs
View File

@ -195,6 +195,10 @@ impl TryFrom<&[u8]> for ByteString {
#[inline] #[inline]
fn try_from(value: &[u8]) -> Result<Self, Self::Error> { fn try_from(value: &[u8]) -> Result<Self, Self::Error> {
if value.is_ascii() {
return Ok(ByteString(Bytes::copy_from_slice(value)));
}
let _ = str::from_utf8(value)?; let _ = str::from_utf8(value)?;
Ok(ByteString(Bytes::copy_from_slice(value))) Ok(ByteString(Bytes::copy_from_slice(value)))
} }
@ -205,6 +209,10 @@ impl TryFrom<Vec<u8>> for ByteString {
#[inline] #[inline]
fn try_from(value: Vec<u8>) -> Result<Self, Self::Error> { fn try_from(value: Vec<u8>) -> Result<Self, Self::Error> {
if value.is_ascii() {
return Ok(ByteString(Bytes::from(value)));
}
let buf = String::from_utf8(value).map_err(|err| err.utf8_error())?; let buf = String::from_utf8(value).map_err(|err| err.utf8_error())?;
Ok(ByteString(Bytes::from(buf))) Ok(ByteString(Bytes::from(buf)))
} }
@ -215,6 +223,10 @@ impl TryFrom<Bytes> for ByteString {
#[inline] #[inline]
fn try_from(value: Bytes) -> Result<Self, Self::Error> { fn try_from(value: Bytes) -> Result<Self, Self::Error> {
if value.is_ascii() {
return Ok(ByteString(value));
}
let _ = str::from_utf8(value.as_ref())?; let _ = str::from_utf8(value.as_ref())?;
Ok(ByteString(value)) Ok(ByteString(value))
} }
@ -225,6 +237,10 @@ impl TryFrom<bytes::BytesMut> for ByteString {
#[inline] #[inline]
fn try_from(value: bytes::BytesMut) -> Result<Self, Self::Error> { fn try_from(value: bytes::BytesMut) -> Result<Self, Self::Error> {
if value.is_ascii() {
return Ok(ByteString(value.freeze()));
}
let _ = str::from_utf8(&value)?; let _ = str::from_utf8(&value)?;
Ok(ByteString(value.freeze())) Ok(ByteString(value.freeze()))
} }
@ -413,7 +429,10 @@ mod test {
#[test] #[test]
fn try_from_slice() { fn try_from_slice() {
let heart = "\u{1f496}";
let _ = ByteString::try_from(b"nice bytes").unwrap(); let _ = ByteString::try_from(b"nice bytes").unwrap();
assert_eq!(ByteString::try_from(heart.as_bytes()).unwrap(), heart);
ByteString::try_from(&[0, 159, 146, 150][..]).unwrap_err();
} }
#[test] #[test]
@ -432,12 +451,22 @@ mod test {
#[test] #[test]
fn try_from_bytes() { fn try_from_bytes() {
let heart = "\u{1f496}";
let _ = ByteString::try_from(Bytes::from_static(b"nice bytes")).unwrap(); let _ = ByteString::try_from(Bytes::from_static(b"nice bytes")).unwrap();
assert_eq!(
ByteString::try_from(Bytes::from_static(heart.as_bytes())).unwrap(),
heart
);
} }
#[test] #[test]
fn try_from_bytes_mut() { fn try_from_bytes_mut() {
let heart = "\u{1f496}";
let _ = ByteString::try_from(bytes::BytesMut::from(&b"nice bytes"[..])).unwrap(); let _ = ByteString::try_from(bytes::BytesMut::from(&b"nice bytes"[..])).unwrap();
assert_eq!(
ByteString::try_from(bytes::BytesMut::from(heart.as_bytes())).unwrap(),
heart
);
} }
#[test] #[test]